5 ms·
It's mildly interesting that the neovim patch for this [1] is just an import of the upstream vim patch [2], but with the test removed. 1: https://github.com/ne
by bla3 7y ago
It's mildly interesting that the neovim patch for this [1] is just an import of the upstream vim patch [2], but with the test removed.
1: https://github.com/neovim/neovim/commit/4553fc5e https://github.com/neovim/neovim/commit/4553fc5e
2: https://github.com/vim/vim/commit/5357552 https://github.com/vim/vim/commit/5357552
- ryanar 7y agoI wonder if it is because neovim's testing is setup differently and they wanted to port the patch immediately rather than spend time which they might not have had at the moment to rewrite the test. I suppose the patch was tested upstream, though you would want the test in neovim to prevent a future regression.
- justinnhli 7y agoA different PR is still open, that presumably would include the test: https://github.com/neovim/neovim/pull/10052 https://github.com/neovim/neovim/pull/10052