3 ms·
Interesting thought! What about if there's not really anything there to "praise", but it's just a chunk of code with some things that are off?
by finaliteration 7y ago
Interesting thought! What about if there's not really anything there to "praise", but it's just a chunk of code with some things that are off?
- mikece 7y agoHave a conversation. As a code reviewer you're looking to increase the understanding of the person whose code you're reviewing -- which starts with understanding why they wrote the code they way they did. Some people simply understand things differently and what's intuitive to them isn't to others. Consider the code sample I talk about in the following blog post: the only thing that's "wrong" about it is that it's probably not obvious to anyone other than the author. URL: http://www.mikece.com/2015/08/clean-code-vs-really-clever-code/ http://www.mikece.com/2015/08/clean-code-vs-really-clever-co...