5 ms·
That is not part of xerrors at this point. Rationale: https://github.com/golang/go/issues/29934#issuecomment-464201672 https://github.com/golang/go/issues/29934
by acrispino 7y ago
That is not part of xerrors at this point. Rationale: https://github.com/golang/go/issues/29934#issuecomment-464201672 https://github.com/golang/go/issues/29934#issuecomment-46420...
Personally, I don't care for "string magic"
Edit: Instead of making another post, I'll add this here. It also feels odd that concerns about xerrors.As possibly panicking at runtime are considered addressed by the addition of a go vet check: https://github.com/golang/go/issues/29934#issuecomment-462522310 https://github.com/golang/go/issues/29934#issuecomment-46252...
I am not opposed to go vet, to be clear, but one of the aspects of the go compiler is that it does not warn, only errors out if compilation can't proceed. But the design of xerrors.As is fine because go vet acts like a compiler warning might? This is an aesthetic complaint more than anything else, but it still doesn't sit right with me.
- llimllib 7y agoThank you, my bad!