3 ms·
Imperative vs past is a stylistic issue and in the end doesn't impact how the commit message is understood. My understanding is that pull request is a GitHub-i
by andreareina 8y ago
Imperative vs past is a stylistic issue and in the end doesn't impact how the commit message is understood.
My understanding is that pull request is a GitHub-ism. What git itself has is `git format-patch`, which does exactly what it says on the tin.
- u801e 8y ago> My understanding is that pull request is a GitHub-ism. It is, but git has a command called request-pull[1]. Linus Torvalds has said[2] that certain aspects of the Github pull request process are not suitable or make it very difficult to submit patchsets for review for the linux kernel and that they should have followed the implemention used in git-request-pull instead. [1] https://git-scm.com/docs/git-request-pull https://git-scm.com/docs/git-request-pull [2] https://github.com/torvalds/linux/pull/17#issuecomment-5654674 https://github.com/torvalds/linux/pull/17#issuecomment-56546...
- andreareina 8y agoDidn't know about request-pull, thanks!