4 ms·
One of the thing about code review I found sad is that many engineers have big ego. Time to time, I see review like: "This is confused to me" and the person wh
by kureikain 8y ago
One of the thing about code review I found sad is that many engineers have big ego.
Time to time, I see review like: "This is confused to me" and the person who write that code explains a lot but refuse to make chances...I think those don't assume good intention in code review.
We aren't in school anymore. We are all get paid to work on something and to help the companies success, or the next engineer to success. When people spend time review your code, read your code, being thankful for these free advice.
I learned so much and thank deeply to people who review my code literally line by line.
The extra emoji, tactic, micro-promotions etc add no value to my learning experience.
- BeetleB 8y ago>Time to time, I see review like: "This is confused to me" and the person who write that code explains a lot but refuse to make chances...I think those don't assume good intention in code review. The flip side to the coin is that "This is confusing to me" is not particularly useful feedback. It reminds me of my days in academia, where professors told students they can't help them if they come to them and merely say "I don't understand this." You have to give more details.