3 ms·
Probably because you don't work on systems anywhere near the scale of Facebook. Facebook has 2.3 billion MAUs, so if they had some edge case that hit 0.1% of us
by hn_throwaway_99 8y ago
Probably because you don't work on systems anywhere near the scale of Facebook. Facebook has 2.3 billion MAUs, so if they had some edge case that hit 0.1% of users, that's already 2.3 million users.
- nihonde 8y agoAnd what does scale have to do with logging any plaintext passwords?
- hn_throwaway_99 8y agoBecause it was a bug. They most likely weren't doing this: log(request.password); But they had some code that did this: log(excludeSensitive(request. headers)); But then someone on a different team changed how passwords were sent so excludeSensitive was broken.
- nihonde 8y agoScrubbing passwords and other sensitive information from logs is such a basic requirement. It’s something you write a regression test for and never think about again.