3 ms·
I left Google about a month ago and use Github now. Things I miss: - the ability to batch all comments in a single send. GitHub has the problem where replies a
by sa46 8y ago
I left Google about a month ago and use Github now. Things I miss:
- the ability to batch all comments in a single send. GitHub has the problem where replies are immediate and don’t necessarily represent the PR state.
- built-in fixes and lints that show up as comments
- the ability to diff between snapshots instead of losing all previous context every force push to a Github PR.
- Github’s diff is really bad for code moving or changing indentation.
- auto submit if tests pass and you have an lgtm. It’s frustrating having to wait for tests that will probably pass.
- sqs 8y agoThanks! GitHub actually does some of these things already. Do these solutions help/suffice? - Batching all comments in a single send: This is a core GitHub code review feature. You can send immediately by pressing the "Add single comment" button, but if you "Start a review", your comments are batched. - Built-in fixes and lints on the PR "Files changed" tab: GitHub Checks offer this, although not many teams have adopted it (that I'm aware of). - Changing indentation: The "Diff settings" menu has a "Hide whitespace changes" option, although it's not (afaik) possible to persist this. - Auto-submit if tests pass: The Refined GitHub browser extension offers this (https://github.com/sindresorhus/refined-github https://github.com/sindresorhus/refined-github), kind of. You need to keep the page open in your browser while it finishes. Also, have you seen https://reviewable.io/ https://reviewable.io/ (made by an Xoogler) and does that appeal to you?
- puzzle 8y agoI miss TBR=. You should rarely use it, by design, but in those few occasions where it's warranted, it's very nice.