5 ms·

Is the implication that every library module with async code must be rewritten to use promises or else be obsolete?

• snek 8y ago
  it's not just promises. as the maintainers of request continue trying to try to fix architectural bugs they are finding it would be easier to rewrite it from scratch rather than continue modifying the current one. this is said in about as many words in the linked issue too, so make sure you read before commenting ;)
  • HatchedLake721 8y ago
    "easier to rewrite from scratch" is a fallacy. https://www.joelonsoftware.com/2000/04/06/things-you-should-never-do-part-i/ https://www.joelonsoftware.com/2000/04/06/things-you-should-...
    • matt_kantor 8y ago
      "Easier to fix if they allow themselves to completely break the public API" was how I interpreted the situation with request.
      • HatchedLake721 8y ago
        That's what MAJOR stands for in semver - when you make incompatible/breaking API changes
        • matt_kantor 8y ago
          Right. Are you saying that you think request should make these changes and go through a major version bump? The linked issue talks in depth about why they don't want to do that.