4 ms·
As with everything, depends on the audience. If working on something web-related or has an obvious need for javascript, then yeah, node can be an assumed depend
by akubera 8y ago
As with everything, depends on the audience. If working on something web-related or has an obvious need for javascript, then yeah, node can be an assumed dependency (actually probably preferred because I'd imagine you get better integration with the rest of your project than with unittest/pytest). But if it's a pure-python library that has nothing to do with javascript/typescript I think it's too much to ask someone to be sure to install proper versions of node+npm+typescript+whatever-else so your `python setup.py test` runs correctly. The same would apply to a javascript project that had dependency on python3.6 for their type checker.
Many projects need node, but not all; I don't know any which require docker.
I want to be clear: with pyright, it's not bad! I think it's the right way to do the LSP plugin: no dependency on the current python version (am I using the python in the venv? or ~/.local/bin? or /usr/bin/?) and great integration with the editor.
If it's a large project that will benefit from "5x faster" typechecking than mypy, then yeah, it's probably worth the dependencies.
If you have a 5-file python package I found on pypi that I want to contribute to, but there's nonstandard hoops to jump through to get `python setup.py test` working properly, I would have preferred you made a different call in this regard.
I'm glad we have choices and it's not mono-culture.
- rattray 8y agoAgreed; there are some projects, like pure-python libraries, for whom Node would be a dealbreaker.