2 ms·

How is saying "it's shit" is "constructive feedback" ? What is the constructive part ? I'm not offended when developers say that, I just observe that they are

• ElBarto 8y ago
  Their abilities as developers are judged by what they deliver. Obviously they need to deliver before they can call someone else's code "shit", or at least before they can say that and be taken seriously...
• geezerjay 8y ago
  > How is saying "it's shit" is "constructive feedback" ? It means the contribution isn't up to the standards and therefore can't be integrated, and thus informing the contributor that he needs to improve his work in specific aspects in order to avoid similar problems. > What is the constructive part ? You're focusing too much on irrelevant aspects of the communication (i.e., which and how a word was used) and in the process ignoring (intentionally or not) what was actually said. Typically linus includes specific comments on the problems present or caused by a contribution, whether in code or the development process. In the very least it's very easy to understand that this sort of process works through negative feedback.