4 ms·
Ya, that's one reason I rewrite the commit message to add the CVE. Hopefully people will view the blame before changing.
by tenderlove 8y ago
Ya, that's one reason I rewrite the commit message to add the CVE. Hopefully people will view the blame before changing.
- decasia 8y agoI'm curious — is it not normal to add in-line explanatory comments in the Rails codebase? I'm thinking if I were writing this code in an application, and it looked this cryptic, I might at least add a comment noting what it was for. Not that people shouldn't look in git. But inline is easier to notice, no?
- riffraff 8y agoDon't we have tests for this?
- progval 8y agoThe tests are far from obvious too https://github.com/rails/rails/commit/f4c70c2222180b8d9d924f00af0c7fd632e26715#diff-10fcdd9642eb5b16366cccceb7da3116 https://github.com/rails/rails/commit/f4c70c2222180b8d9d924f...