3 ms·
The critical point is unboundedly attacker-controlled sizes. A reasonable limit, specified and then carried into the implementation, would've prevented this bug
by userbinator 8y ago
The critical point is unboundedly attacker-controlled sizes. A reasonable limit, specified and then carried into the implementation, would've prevented this bug easily.
Speaking of limits, this is something that I think deserves more attention in education --- does the algorithm or code you create work for all inputs, especially those at the limits? Are you even able to determine those limits? Why does a path in D-Bus need to have a 32-bit length? Is 16 (64K) or even 8 (255) bits sufficient? If not, why? Can it be made sufficient?
Asking the important questions, learning, and understanding is ultimately going to be a far more useful than the current "just cut off the limb" attitude toward security that seems so prevalent today. Those questions should've all been asked and clearly answered at the design stage.
- saagarjha 8y agoRather, I'd say the critical points are that systemd has critical issues it absolutely should not be having, with the state of tooling we have today (taint analysis, heck, even a good linter might have been able to find this!). When the last thing came out someone I know told me that they had just glanced through the codebase and were not surprised that it had bugs like this; I think his exact words were something like "you don't have code like this in 2019".
- flukus 8y ago> Why does a path in D-Bus need to have a 32-bit length? Is 16 (64K) or even 8 (255) bits sufficient? I'm not sure what path is in this context but if I assume file path (the rest of my post will look stupid if it's not) then 16 seems more than enough, but 8 has bitten many people in the windows world before. I'm also unsure of the context, is it always a path or is it a generic message that will be a path in this context? If it's the latter then there are many instances where 32-bit makes sense and then regardless of what is suitable for a path the 32-bit length is the contract.