7 ms·
Systemd (PID1) crash with specially crafted D-Bus message
- saagarjha 8y ago> allocates a buffer on the stack > the length of this is attacker controlled This isn't the first time this has happened (https://www.openwall.com/lists/oss-security/2019/01/09/3 https://www.openwall.com/lists/oss-security/2019/01/09/3). Uninformed opinion, but can we just like not stack allocate things, especially if their size is attacker-controlled? Linux has already moved away from VLAs for security reasons, I don't see why systemd shouldn't either.
- kccqzy 8y agoLinux has the option of simply refusing your request and returning -ENOMEM. Is this an option for systemd?
- saagarjha 8y agoI don't see how this would help in this case? If systemd could detect it was going to overflow the stack, there's no vulnerability…
- kccqzy 8y agoI mean, if we avoid stack allocation, then perhaps we need to instead allocate on the heap. What if malloc fails then? Can systemd return an error code? Or do we instead have a DoS problem?
- saagarjha 8y ago> Linux has the option of simply refusing your request and returning -ENOMEM. Is this an option for systemd? > if we avoid stack allocation, then perhaps we need to instead allocate on the heap That's what the fix does: https://github.com/systemd/systemd/commit/f519a19bcd5afe674a9b8fc462cd77d8bad403c1#diff-88d4b05d65f1377f716024145dc65d16 https://github.com/systemd/systemd/commit/f519a19bcd5afe674a...
- jancsika 8y agoWhat are the examples of VLA-related bugs in the Linux kernel like? Are they as stark as this one?
- pjmlp 8y agoCheck the Kernel Security Protection Project sponsored by Google, they are the ones driving the removal of all VLA uses on the kernel.
- userbinator 8y agoThe critical point is unboundedly attacker-controlled sizes. A reasonable limit, specified and then carried into the implementation, would've prevented this bug easily. Speaking of limits, this is something that I think deserves more attention in education --- does the algorithm or code you create work for all inputs, especially those at the limits? Are you even able to determine those limits? Why does a path in D-Bus need to have a 32-bit length? Is 16 (64K) or even 8 (255) bits sufficient? If not, why? Can it be made sufficient? Asking the important questions, learning, and understanding is ultimately going to be a far more useful than the current "just cut off the limb" attitude toward security that seems so prevalent today. Those questions should've all been asked and clearly answered at the design stage.
- saagarjha 8y agoRather, I'd say the critical points are that systemd has critical issues it absolutely should not be having, with the state of tooling we have today (taint analysis, heck, even a good linter might have been able to find this!). When the last thing came out someone I know told me that they had just glanced through the codebase and were not surprised that it had bugs like this; I think his exact words were something like "you don't have code like this in 2019".
- flukus 8y ago> Why does a path in D-Bus need to have a 32-bit length? Is 16 (64K) or even 8 (255) bits sufficient? I'm not sure what path is in this context but if I assume file path (the rest of my post will look stupid if it's not) then 16 seems more than enough, but 8 has bitten many people in the windows world before. I'm also unsure of the context, is it always a path or is it a generic message that will be a path in this context? If it's the latter then there are many instances where 32-bit makes sense and then regardless of what is suitable for a path the 32-bit length is the contract.
- viraptor 8y agoWeirdly, having this stack-allocated probably saved the day a bit. If it was on the heap, there's a good chance that instead of an unmapped page, you'd hit something actually available.
- rurban 8y agoRust loves it and has no intention to secure/fix it neither. They even call it "memory-safe".
- teddyh 8y agoThis is a month old, and fixes for all major distributions have long since been released: https://security-tracker.debian.org/tracker/CVE-2019-6454 https://security-tracker.debian.org/tracker/CVE-2019-6454
- userbinator 8y agowhich results in the stack pointer moving outside of the bounds of the currently mapped stack region, jumping over the stack guard pages. They don't generate stack probes? I'm used to this behaviour on Windows, where the compiler will generate code to explicitly touch the guard pages if it knows/suspects you may allocate more than a page: https://geidav.wordpress.com/tag/stack-probing/ https://geidav.wordpress.com/tag/stack-probing/ Yes, I know if you try to get it to allocate too much it will still crash, but that would be an "out of stack" error, so I'm a little surprised at that description.
- caf 8y agoDepends on the compiler and compiler options. For GCC: https://gcc.gnu.org/onlinedocs/gcc/Instrumentation-Options.html#index-fstack-clash-protection https://gcc.gnu.org/onlinedocs/gcc/Instrumentation-Options.h...
- kevin_thibedeau 8y agodo { => char prefix[pl+1]; Who do we git blame for this turd? Why hasn't their static analysis tooling found this?
- saagarjha 8y agoTake a guess, or don't: https://github.com/systemd/systemd/commit/7286037fd438e93137571fa68a741cc894d8e549 https://github.com/systemd/systemd/commit/7286037fd438e93137...
- esjeon 8y agoB.e.a.utiful. I mean, he is a good programmer, but I’ve seen him (even in other projects) optimizing codes prematurely, which allows vulnerabilities to slip in. I understand the temptation, but many of his projects are mostly not performance critical. Not a good habit.
- alexeiz 8y agoWhat's your definition of a good programmer? Does the one who writes a lot of code and takes shortcuts meet that definition?
- kevin_thibedeau 8y agoThis isn't an optimization. It is pretending that C is like managed code and using the stack as a glorified garbage collector to avoid the responsibility of freeing memory. He did the same with his alloca() misuse. I would hope that they turn on -Wvla to find any more of these landmines.
- rambojazz 8y agoSorry what is wrong with "char prefix[pl+1]"? Isn't it just an array declaration?
- enqk 8y agopl is a variable. So this array size is variable. What would happen if the allocation cannot be made on the stack?