6 ms·
It’s small and short, but https://github.com/MaxLeiter/maxleiter.github.io/blob/master/index.html https://github.com/MaxLeiter/maxleiter.github.io/blob/master..
by MaxLeiter 8y ago
It’s small and short, but https://github.com/MaxLeiter/maxleiter.github.io/blob/master/index.html https://github.com/MaxLeiter/maxleiter.github.io/blob/master... was my first time exploring elements like aside and article rather than using div in their place
- Theodores 8y agoGetting there... IMHO you need to ditch the wrapper divs and put a single 'main' in there. Then you need to apply CSS Grid to the outer container with something sensible for the outer rows to do the wrapper thing more succinctly. Also get rid of the div around the footer. There are also a few spans too many around the links at the start of each article, if you can do things with pseudo elements instead then I think you will like it that way - moving presentational stuff out the document into the stylesheet. Also be bold with the classes. If you are using elements instead of divs then you can style them without the class tags. Don't take these points as criticisms, there is a lot to unlearn with CSS grid and using proper elements instead of the usual divs. I don't think you need the armbands any more, it is good to see!