23 ms·
I think the most important thing is empathy. It can be pretty hard for some people to put egos aside when doing/receiving code reviews. Other than that, have c
by gusmd 8y ago
I think the most important thing is empathy. It can be pretty hard for some people to put egos aside when doing/receiving code reviews.
Other than that, have clear standards regarding formatting (preferably do it automatically with something like clang-format), build and run a linter/tests on CI so that the most basic things are caught automatically.
Finally, remember the objective is not criticizing someone else's style, since we all have our own, but instead sharing knowledge and improving quality.