8 ms·

Chromium: Improve support for Nintendo Switch gamepads

61 points by pplonski86 8y ago

deleted 8y ago
[deleted]
clanrebornx 8y ago
Wonder why not write it in Go or Rust, c++ limits contribution to old developers only None of my friends know c++ But all of them know Go or Rust.
- dev_north_east 8y ago
  Well the first thing to realise is that you live in a bubble.
  - clanrebornx 8y ago
    Yes, I am in SV. It's a bubble but that shouldn't be a problem, everyone around me is Rust and Go hacker
    - dev_north_east 8y ago
      I'm not in SV but have worked in a few different areas/industries and all are big C++ houses. I'm not old :) I'm in a bubble too. I couldn't name a single friend or colleague who uses Rust or Go. Just for example, scanning the jobs in my city the most in demand are c#, java and c++ in that order.
fvjft 8y ago
Oh good, a link to a pull request instead of some stupid blog full of drivel.
Insanity 8y ago
Not being a C/C++ programmer, I wonder why they postfix their variables with "underscore"? https://chromium-review.googlesource.com/c/chromium/src/+/1510080/13/device/gamepad/gamepad_device_linux.cc https://chromium-review.googlesource.com/c/chromium/src/+/15... e.g: switch_pro_4, dualshock_ps4_, ... It does not happen for all variables, what is this convention? :o
- olig15 8y ago
  I think it's because they're member variables. It makes them clear they're not local to the method.
  - Insanity 8y ago
    At a quick glance, that does seem to be a difference with the postfixed variables! Have not yet encountered something like that in the languages I've worked with. ^^
    - cmrdporcupine 8y ago
      Wait til you discover Hungarian notation?
      - Insanity 8y ago
        That one I actually did encounter somewhere in high school, when a lecturer used it in Visual Basic, for some reason. xD
- cmrdporcupine 8y ago
  Google C++ style guide. It's for instance variables on classes, to distinguish from local variables. https://google.github.io/styleguide/cppguide.html#Variable_Names https://google.github.io/styleguide/cppguide.html#Variable_N...
  - joshvm 8y ago
    Is there a reason for not using 'this'? I assume the risk is that you might have a scope where both this->foo and foo are valid and it's unclear which is which. You have no ambiguitiy with this->foo_, and foo (and if you forget 'this', foo_ is still clear).
    - jcelerier 8y ago
      six characters to type vs 1 ?
wslh 8y ago
Is there a plan to support Chrome in the Nintendo Switch? The rumours (which are mainly speculation or clickbait pages) talk about just supporting the gamepads.
- TwoNineA 8y ago
  Maybe to add controller support for the upcoming Google game streaming console?
- discreditable 8y ago
  If the Switch used a modern webkit/blink and kept it up to date that would close some of the popular jailbreak methods.
owenwil 8y ago
This is a pretty smart move, considering that rumors point to Google's "game streaming service" being available on every device that runs Chrome, without additional installation. That would mean a launch across: * Windows * Mac * ChromeOS * Linux * Mobile ...overnight. Pretty compelling way to draw in new users given millions of people already own a Switch controller and could start without needing to buy Google's one.
- geofft 8y ago
  Is there a reason to believe this is a Google strategic change instead of some individual Chromium hacker who happens to own a Switch and wants to use its controller for fun? (I don't see any more context on the bug, so it seems to be it could be either.)
  - martius 8y ago
    The author has a @google.com email address.
    - geofft 8y ago
      Sure, still could be personal interest. I certainly commit things to my employer's source control that are personally interesting and not company strategic priorities (but still correct changes to make) on occasion.
    - jchw 8y ago
      I'm neither confirming nor denying this theory since I have no idea, but googlers can and do work on stuff that has nothing to do with their job function, even aside from formal 20% projects. Also, I don't know if it's commonplace anymore, but I remember in the past a lot of people that worked on Chrome had @chromium.org addresses, too.
      - mehrdadn 8y ago
        I feel like if it was unrelated to their official work they wouldn't use a google.com address?
aboutruby 8y ago
I made a gist from the base64 patch for easier reading: https://gist.github.com/localhostdotdev/f07d7ba7ae6cac4ea1c8976a41400d43 https://gist.github.com/localhostdotdev/f07d7ba7ae6cac4ea1c8...
retSava 8y ago
OT: I'm quite disappointed by the switch hardware. We're using it lightly in our family, not tugging it around or travel with it. Mostly game with it docked. Ca 1 year old at this time. The controllers have both been plagued by the issue of dust entering the analog sticks, making it drift. You can't calibrate this away (tried it). Nor did it for us help with a spray can of air to blow it away, but perhaps I was holding it wrong (snark). Had to send it away for repair and they changed both analog sticks. A new set of controllers (ie two sticks) also cost almost twice what an official PS4 dualshock controller costs. A single costs about as much as a PS4DS. Also, the PS4 one feels so much more robust. For a controller that is meant to be used on the go, I find the poor dust-resistance and high cost of replacement very off-putting. I get the feeling that they, or something else on the switch, is gonna break again soon. Puh, sorry for the rant.
- moontear 8y ago
  A rant this is. Send them in. You‘ll get new ones without flaws. Dragging my Switch everywhere haven’t had a single problem ever with my joy cons not with the pro Controller. Friends had problems, got their joy cons replaced - all good now.
  - retSava 8y ago
    Do you mean there is a new controller version that is more robust, or simply replaced with ones that aren't (yet) dusty? If the latter, it's just a question of time before one has to do the same ordeal again. I'd prefer the problem not to arise in the first place. But good thing Nintendo are generous with replacements.
    - nolok 8y ago
      No, he is saying the vast majority of people don't have those issues so short of exagerating* you probably have deficient ones, and simply need to get them exchanged for new ones . * you know, like saying "oh this issue is really bothing me but no I won't change them because it would just happen again anyway I'm sure of it even though most of others aren't affected". This is a definite case of "the user is not looking for a solution, but for a chance to rant", we've all seen it one time or another
YUMad 8y ago
Well except two points: - Switch doesn't even have a browser (it does technically, but it's internally used and you need to hack the switch to be able to use the browser) - Nintendo could easily change this if they wanted, of course, but considering their history of tight control over the platform, I don't think they'd be willing.
- geofft 8y ago
  This is for support for Nintendo Switch gamepads when connected to a normal computer over USB or Bluetooth, not for running Chromium itself on the Switch console.
yegle 8y ago
Huh that's weird. I was a beta tester of Project Stream during the holiday season. I travelled with a Pixelbook and before my travel I tested all my controllers: PS4/Xbox/Nintendo and even an NVIDIA shield controller. Only Nintendo Pro Switch controller can be paired with the Chromebook. The only problem is that A/B and X/Y is different between Xbox and Nintendo controller and you need to press B when the game tells you to press A. But it's a minor issue.
- verall 8y ago
  The first shield controller was wifi-direct and so compatible with almost nothing. The new one is Bluetooth. Do you know which one you had?
- vinkelhake 8y ago
  I was also a beta tester of Project Stream. DualShock 4 controllers can be paired with Pixelbooks. I know because that's what I used.
- mikewhy 8y ago
  > The only problem is that A/B and X/Y is different between Xbox and Nintendo controller and you need to press B when the game tells you to press A. But it's a minor issue. It's also different with Xbox and PS4 controllers. It's something I got used to a while ago after using DS3 controllers in Windows games. Lots of PC games nowadays detect PS4 controllers and properly adjust UI (or even work with the lightbar), but I doubt Project Stream / browser controller APIs get that level of info.

61 points by pplonski86 8y ago

deleted 8y ago

[deleted]

Wonder why not write it in Go or Rust, c++ limits contribution to old developers only None of my friends know c++ But all of them know Go or Rust.

dev_north_east 8y ago
Well the first thing to realise is that you live in a bubble.
- clanrebornx 8y ago
  Yes, I am in SV. It's a bubble but that shouldn't be a problem, everyone around me is Rust and Go hacker
  - dev_north_east 8y ago
    I'm not in SV but have worked in a few different areas/industries and all are big C++ houses. I'm not old :) I'm in a bubble too. I couldn't name a single friend or colleague who uses Rust or Go. Just for example, scanning the jobs in my city the most in demand are c#, java and c++ in that order.

fvjft 8y ago

Oh good, a link to a pull request instead of some stupid blog full of drivel.

Insanity 8y ago

Not being a C/C++ programmer, I wonder why they postfix their variables with "underscore"? https://chromium-review.googlesource.com/c/chromium/src/+/1510080/13/device/gamepad/gamepad_device_linux.cc https://chromium-review.googlesource.com/c/chromium/src/+/15... e.g: switch_pro_4, dualshock_ps4_, ... It does not happen for all variables, what is this convention? :o

olig15 8y ago
I think it's because they're member variables. It makes them clear they're not local to the method.
- Insanity 8y ago
  At a quick glance, that does seem to be a difference with the postfixed variables! Have not yet encountered something like that in the languages I've worked with. ^^
  - cmrdporcupine 8y ago
    Wait til you discover Hungarian notation?
    - Insanity 8y ago
      That one I actually did encounter somewhere in high school, when a lecturer used it in Visual Basic, for some reason. xD
cmrdporcupine 8y ago
Google C++ style guide. It's for instance variables on classes, to distinguish from local variables. https://google.github.io/styleguide/cppguide.html#Variable_Names https://google.github.io/styleguide/cppguide.html#Variable_N...
- joshvm 8y ago
  Is there a reason for not using 'this'? I assume the risk is that you might have a scope where both this->foo and foo are valid and it's unclear which is which. You have no ambiguitiy with this->foo_, and foo (and if you forget 'this', foo_ is still clear).
  - jcelerier 8y ago
    six characters to type vs 1 ?

wslh 8y ago

Is there a plan to support Chrome in the Nintendo Switch? The rumours (which are mainly speculation or clickbait pages) talk about just supporting the gamepads.

TwoNineA 8y ago
Maybe to add controller support for the upcoming Google game streaming console?
discreditable 8y ago
If the Switch used a modern webkit/blink and kept it up to date that would close some of the popular jailbreak methods.

owenwil 8y ago

This is a pretty smart move, considering that rumors point to Google's "game streaming service" being available on every device that runs Chrome, without additional installation. That would mean a launch across: * Windows * Mac * ChromeOS * Linux * Mobile ...overnight. Pretty compelling way to draw in new users given millions of people already own a Switch controller and could start without needing to buy Google's one.

geofft 8y ago
Is there a reason to believe this is a Google strategic change instead of some individual Chromium hacker who happens to own a Switch and wants to use its controller for fun? (I don't see any more context on the bug, so it seems to be it could be either.)
- martius 8y ago
  The author has a @google.com email address.
  - geofft 8y ago
    Sure, still could be personal interest. I certainly commit things to my employer's source control that are personally interesting and not company strategic priorities (but still correct changes to make) on occasion.
  - jchw 8y ago
    I'm neither confirming nor denying this theory since I have no idea, but googlers can and do work on stuff that has nothing to do with their job function, even aside from formal 20% projects. Also, I don't know if it's commonplace anymore, but I remember in the past a lot of people that worked on Chrome had @chromium.org addresses, too.
    - mehrdadn 8y ago
      I feel like if it was unrelated to their official work they wouldn't use a google.com address?

aboutruby 8y ago

I made a gist from the base64 patch for easier reading: https://gist.github.com/localhostdotdev/f07d7ba7ae6cac4ea1c8976a41400d43 https://gist.github.com/localhostdotdev/f07d7ba7ae6cac4ea1c8...

retSava 8y ago

OT: I'm quite disappointed by the switch hardware. We're using it lightly in our family, not tugging it around or travel with it. Mostly game with it docked. Ca 1 year old at this time. The controllers have both been plagued by the issue of dust entering the analog sticks, making it drift. You can't calibrate this away (tried it). Nor did it for us help with a spray can of air to blow it away, but perhaps I was holding it wrong (snark). Had to send it away for repair and they changed both analog sticks. A new set of controllers (ie two sticks) also cost almost twice what an official PS4 dualshock controller costs. A single costs about as much as a PS4DS. Also, the PS4 one feels so much more robust. For a controller that is meant to be used on the go, I find the poor dust-resistance and high cost of replacement very off-putting. I get the feeling that they, or something else on the switch, is gonna break again soon. Puh, sorry for the rant.

moontear 8y ago
A rant this is. Send them in. You‘ll get new ones without flaws. Dragging my Switch everywhere haven’t had a single problem ever with my joy cons not with the pro Controller. Friends had problems, got their joy cons replaced - all good now.
- retSava 8y ago
  Do you mean there is a new controller version that is more robust, or simply replaced with ones that aren't (yet) dusty? If the latter, it's just a question of time before one has to do the same ordeal again. I'd prefer the problem not to arise in the first place. But good thing Nintendo are generous with replacements.
  - nolok 8y ago
    No, he is saying the vast majority of people don't have those issues so short of exagerating* you probably have deficient ones, and simply need to get them exchanged for new ones . * you know, like saying "oh this issue is really bothing me but no I won't change them because it would just happen again anyway I'm sure of it even though most of others aren't affected". This is a definite case of "the user is not looking for a solution, but for a chance to rant", we've all seen it one time or another

YUMad 8y ago

Well except two points: - Switch doesn't even have a browser (it does technically, but it's internally used and you need to hack the switch to be able to use the browser) - Nintendo could easily change this if they wanted, of course, but considering their history of tight control over the platform, I don't think they'd be willing.

geofft 8y ago
This is for support for Nintendo Switch gamepads when connected to a normal computer over USB or Bluetooth, not for running Chromium itself on the Switch console.

yegle 8y ago

Huh that's weird. I was a beta tester of Project Stream during the holiday season. I travelled with a Pixelbook and before my travel I tested all my controllers: PS4/Xbox/Nintendo and even an NVIDIA shield controller. Only Nintendo Pro Switch controller can be paired with the Chromebook. The only problem is that A/B and X/Y is different between Xbox and Nintendo controller and you need to press B when the game tells you to press A. But it's a minor issue.

verall 8y ago
The first shield controller was wifi-direct and so compatible with almost nothing. The new one is Bluetooth. Do you know which one you had?
vinkelhake 8y ago
I was also a beta tester of Project Stream. DualShock 4 controllers can be paired with Pixelbooks. I know because that's what I used.
mikewhy 8y ago
> The only problem is that A/B and X/Y is different between Xbox and Nintendo controller and you need to press B when the game tells you to press A. But it's a minor issue. It's also different with Xbox and PS4 controllers. It's something I got used to a while ago after using DS3 controllers in Windows games. Lots of PC games nowadays detect PS4 controllers and properly adjust UI (or even work with the lightbar), but I doubt Project Stream / browser controller APIs get that level of info.