7 ms·
I like this process, although I'm not as consistent as I'd like to be about answering in comments rather than in the review tool. As an addendum to this, I hav
by splonk 8y ago
I like this process, although I'm not as consistent as I'd like to be about answering in comments rather than in the review tool. As an addendum to this, I have a general rule for code review: the developer doesn't get to push back on any (correct) request for comment/renaming/clarification. I'm prepared to accept that the fact that somebody felt the need to ask something is proof enough that the code in question isn't as obvious as I thought.