3 ms·

Thanks for the feedback! >For example, it should be useful to move the top navigation bar into a big colored menu bar, like on github or on HN. I tried this b

Thanks for the feedback! >For example, it should be useful to move the top navigation bar into a big colored menu bar, like on github or on HN. I tried this but I really dislike it: https://sr.ht/QhUN.png https://sr.ht/QhUN.png It's just sooo distracting to me, and it plays up sourcehut as being more important to the visitor than the content they came for, imo. >Imho the summary tab should show the files in the repo, as Github does I disagree here as well, just as a matter of taste. >A useful rule for links is that all links should be colored as long as they are not in a navigation area >It's a bit strange that the top navigation has a highlight on link hover, the second one does not (summary, tree, log, ...) Aye, I'm going to revisit this. >Your css applies `font-size: .9rem;`, it shouldn't. That's often ignored and who am I to preach design, but I have the absolute conviction that body text should not be messed with. Trust in the browser, keep it as is, just make headings bigger and detail elements a little bit smaller, the latter only when absolutely needed. Fits to your design philosophy anyway. >Your css applies `font-size: .9rem;`, it shouldn't. That's often ignored and who am I to preach design, but I have the absolute conviction that body text should not be messed with. Trust in the browser, keep it as is, just make headings bigger and detail elements a little bit smaller, the latter only when absolutely needed. Fits to your design philosophy anyway. I'll think about this. Thanks for sharing your thoughts!

onli 8y ago
The coloured top navigation will not take the focus away, people are too used to navigation areas for that. It will help them however to separate the areas of the page. It's just very strange for you as you are too used to the existing design :) However, the contrast between the inactive menu elements and the background might be a bit low. And sure, there is a visual branding part in play here as well that you might want to think about a bit longer. Something else than a black bar could work better in that regard, maybe white with a small border and a shadow below? Something a bit more in line with the current design will ease the transition. But I think it absolutely works a lot better than the current whitespacy solution. Maybe ask a few people more for their impression? I'd be very surprised if it does not work better for most.
onli 8y ago
Just in case you are not already bored thinking about the design of this ;) My header and font size remarks would result in something like this: https://screenshots.firefox.com/UbXL8WRNN95pfYRm/git.sr.ht https://screenshots.firefox.com/UbXL8WRNN95pfYRm/git.sr.ht (strangely, the shadow looks better in the browser). That's of course not completely done nor a fix-all. There might be an alignment issue with the navbar entries and the sourcehut logo? It also made me think about the file header (git.sr.ht/gitsrht/service.py -rw-r--r-- 3.0 KiB View raw), that one needs a bit of structure, and that darker grey next to the different line number grey looks strange. body font size removed, but I kept making the code font size smaller (code normally is smaller still) and reduced the line height there to 1.2. h2 font size reduced as well, but whether that's the right size depends on the ratio chosen for the other hs. One remark more: > > Imho the summary tab should show the files in the repo, as Github does > I disagree here as well, just as a matter of taste. This shouldn't be a matter of taste. It's a matter of what helps users gets the job done better. It's a question to observe during a user test.

onli 8y ago

The coloured top navigation will not take the focus away, people are too used to navigation areas for that. It will help them however to separate the areas of the page. It's just very strange for you as you are too used to the existing design :) However, the contrast between the inactive menu elements and the background might be a bit low. And sure, there is a visual branding part in play here as well that you might want to think about a bit longer. Something else than a black bar could work better in that regard, maybe white with a small border and a shadow below? Something a bit more in line with the current design will ease the transition. But I think it absolutely works a lot better than the current whitespacy solution. Maybe ask a few people more for their impression? I'd be very surprised if it does not work better for most.

onli 8y ago

Just in case you are not already bored thinking about the design of this ;) My header and font size remarks would result in something like this: https://screenshots.firefox.com/UbXL8WRNN95pfYRm/git.sr.ht https://screenshots.firefox.com/UbXL8WRNN95pfYRm/git.sr.ht (strangely, the shadow looks better in the browser). That's of course not completely done nor a fix-all. There might be an alignment issue with the navbar entries and the sourcehut logo? It also made me think about the file header (git.sr.ht/gitsrht/service.py -rw-r--r-- 3.0 KiB View raw), that one needs a bit of structure, and that darker grey next to the different line number grey looks strange. body font size removed, but I kept making the code font size smaller (code normally is smaller still) and reduced the line height there to 1.2. h2 font size reduced as well, but whether that's the right size depends on the ratio chosen for the other hs. One remark more: > > Imho the summary tab should show the files in the repo, as Github does > I disagree here as well, just as a matter of taste. This shouldn't be a matter of taste. It's a matter of what helps users gets the job done better. It's a question to observe during a user test.