4 ms·
Half of this works well; some of the redesign of tabs, the elimination of icons, and similar changes look great. On the other hand, showing the last commit and
by JoshTriplett 8y ago
Half of this works well; some of the redesign of tabs, the elimination of icons, and similar changes look great.
On the other hand, showing the last commit and change time for each file is useful. Where is that information now? It's in a linear commit list, which is helpful for different purposes ("when was the repo last updated and what's up?") but doesn't serve the original purposes as well ("when was this file updated?"). At the very least, the last-changed date would help.
Shoving statistics over on the right-hand side makes the page much more crowded; expanding the space available for files and commits would work better. Notice how the commit list has messages truncated; 70-to-80-character commit messages ought to fit comfortably there.
Where does the README appear, here? That tends to be the first thing I'm looking for in a new project, and it doesn't look like this redesign took that into account at all.
The new extra-busy tab bar makes it harder to get at the things you use every day: issues and pull requests.
- dcosson 8y agoI was half onboard with his reasoning to remove the commit messages. But then I realized, they're only useless if they're bad commit messages. Especially if you're using PRs and using "squash + merge" for all your changes (which should really be the default IMO) the commit messages will be the PR titles and PR number and that's pretty useful. And then the commit time for the file is obviously super important. What else might be really cool is some kind of indicator of how often the file changes, in addition to the most recent change. Like sometimes if you see a file, maybe it was changed 2 days ago but only because someone renamed a method and that made a one-line change in 50 files. But before that, when was it changed? Does it usually change multiple times a week, or was this the only time it changed in the past month? Even if it was just a rough color gradient or something it would be pretty cool to see at a glance which are the most active directories and files in your repo.
- userbinator 8y agoAnd then the commit time for the file is obviously super important. What's nice about git is that you also get this propagating to the directories all the way up to the root, so you can quite easily see which areas of the code have been changed recently too. This isn't something normal filesystems have (for performance reasons more than anything --- I imagine if one tried to use git as a filesystem such that each file change was an actual git commit, the root directory node would be hammered with constant updates and an enormous bottleneck) but in the context of a VCS it's amazingly useful.
- JoshTriplett 8y ago> What's nice about git is that you also get this propagating to the directories all the way up to the root, so you can quite easily see which areas of the code have been changed recently too. Exactly! It's easy to see at a glance, for instance, that the code changed recently but the documentation hasn't been updated in a long time. Or that the LICENSE file just got updated a few days ago. Or that a new top-level module got introduced.
- JoshTriplett 8y ago> Especially if you're using PRs and using "squash + merge" for all your changes (which should really be the default IMO) I tend to use either "rebase" or "merge" for everything, and I expect people submitting PRs to make good commits. > What else might be really cool is some kind of indicator of how often the file changes That's a good idea! How about a sparkline-sized indicator of change activity over time? https://en.wikipedia.org/wiki/Sparkline https://en.wikipedia.org/wiki/Sparkline
- jonnycomputer 8y agobingo.