3 ms·

Two nitpicks: 1. Why are the images cropped so strangely on mobile? It makes this article really hard to read. 2. Shouldn’t the title be “Redesigning the GitH

Two nitpicks: 1. Why are the images cropped so strangely on mobile? It makes this article really hard to read. 2. Shouldn’t the title be “Redesigning the GitHub Repository Page”? ^ And a meta question for programmers, what do you do when English grammar calls for a question mark to be inside your quotation mark at the end of a sentence, but you’re literally quoting something that should not include the question mark? It’s grammatically wrong, but I’ve taken to moving the question mark outside in the case to avoid ambiguity.

alanbernstein 8y ago
I've been ignoring that rule of English grammar for as long as I can remember; it makes no sense.
saagarjha 8y ago
I'd title this "Redesigning GitHub Repository Pages". And I don't put punctuation inside quotes, unless I'm quoting an actual person's speech. I guess that's what I find most natural :/
JoshTriplett 8y ago
> And a meta question for programmers, what do you do when English grammar calls for a question mark to be inside your quotation mark at the end of a sentence, but you’re literally quoting something that should not include the question mark? It’s grammatically wrong, but I’ve taken to moving the question mark outside in the case to avoid ambiguity. If rules and correctness disagree, correctness wins. English is not prescriptive, it's descriptive.
tom_ 8y ago
You can do what you like in British English - so, worst case, people will just assume you're from the UK.
JonathonW 8y ago
> what do you do when English grammar calls for a question mark to be inside your quotation mark at the end of a sentence, but you’re literally quoting something that should not include the question mark? AP style (at least, according to the cheatsheets I've found online; I don't have access to the current edition of the full guide) only puts periods and commas inside quotation marks-- question marks, exclamation points, semicolons, and other punctuation only go inside quotation marks if they belong to the quoted matter. So, that makes "Shouldn’t the title be 'Redesigning the GitHub Repository Page'?" correct, according to them, at least. (This is a matter of style more than a matter of grammar, though.)
- int_19h 8y ago
  That's the best argument I've ever heard for always put everything consistently after the closing quotation mark.
mxcrossb 8y ago
The Yoda fork of the English language fixed this. The correct way is: “Redesigning the Github Repository Page” shouldn’t the title be?
frosted-flakes 8y ago
> what do you do when English grammar calls for a question mark to be inside your quotation mark at the end of a sentence English grammar doesn't call for it, not necessarily. It's a matter of style, and different style guides prescribe different methods. There's no "officially correct" way, but to me, the only position that makes sense is to put trailing punctuation outside the quotation marks, except in the case where said punctuation is actually part of the source material. Doing otherwise can change the meaning of the quotation.

alanbernstein 8y ago

I've been ignoring that rule of English grammar for as long as I can remember; it makes no sense.

saagarjha 8y ago

I'd title this "Redesigning GitHub Repository Pages". And I don't put punctuation inside quotes, unless I'm quoting an actual person's speech. I guess that's what I find most natural :/

JoshTriplett 8y ago

> And a meta question for programmers, what do you do when English grammar calls for a question mark to be inside your quotation mark at the end of a sentence, but you’re literally quoting something that should not include the question mark? It’s grammatically wrong, but I’ve taken to moving the question mark outside in the case to avoid ambiguity. If rules and correctness disagree, correctness wins. English is not prescriptive, it's descriptive.

tom_ 8y ago

You can do what you like in British English - so, worst case, people will just assume you're from the UK.

JonathonW 8y ago

> what do you do when English grammar calls for a question mark to be inside your quotation mark at the end of a sentence, but you’re literally quoting something that should not include the question mark? AP style (at least, according to the cheatsheets I've found online; I don't have access to the current edition of the full guide) only puts periods and commas inside quotation marks-- question marks, exclamation points, semicolons, and other punctuation only go inside quotation marks if they belong to the quoted matter. So, that makes "Shouldn’t the title be 'Redesigning the GitHub Repository Page'?" correct, according to them, at least. (This is a matter of style more than a matter of grammar, though.)

int_19h 8y ago
That's the best argument I've ever heard for always put everything consistently after the closing quotation mark.

mxcrossb 8y ago

The Yoda fork of the English language fixed this. The correct way is: “Redesigning the Github Repository Page” shouldn’t the title be?

frosted-flakes 8y ago

> what do you do when English grammar calls for a question mark to be inside your quotation mark at the end of a sentence English grammar doesn't call for it, not necessarily. It's a matter of style, and different style guides prescribe different methods. There's no "officially correct" way, but to me, the only position that makes sense is to put trailing punctuation outside the quotation marks, except in the case where said punctuation is actually part of the source material. Doing otherwise can change the meaning of the quotation.