5 ms·

We also enforce this. Not for personal or aesthetic reasons, but to keep code reviewers sane and let them review code side-by-side (as many devs do) when they m

We also enforce this. Not for personal or aesthetic reasons, but to keep code reviewers sane and let them review code side-by-side (as many devs do) when they might not have an ultra-wide monitor available.

ncmncm 8y ago
Anything that makes code review harder or less comfortable is deeply destructive to code quality. It is entirely hard enough to get people to do meaningful review without kneecapping them by obliging them to side-scroll just to see what changed.
quink 8y ago
Unified diffs beat side-by-side the majority of the time IMO.
- dkersten 8y ago
  I disagree. I personally find side-by-side easier the majority of the time (although for some cases, unified is easier, eg when I have a single line with a word or character changed).
- u801e 8y ago
  I personally find the output of diff with the -e option most readable ;)
rightbyte 8y ago
What tabsize do you enforce and how many meetings were it before a number was agreed upon?
- guitarbill 8y ago
  Doesn't matter. What matters is consistency in the repo. To this effect, it's important the CI process enforces it - code reviewers could never do it, and it's a waste of their time. I highly recommend auto-formatters like Black, Prettier, Gofmt, etc. They take so much cognitive load off devs and reviewers, it's completely worth it. (In practice, this means whoever sets up the CI process gets to decide :P)