3 ms·
> - Code looks pretty sane. Structure is right. Style seems good. You're attributing that bullet point to the wrong developer. Here's a profile of a reviewer:
by jancsika 8y ago
> - Code looks pretty sane. Structure is right. Style seems good.
You're attributing that bullet point to the wrong developer.
Here's a profile of a reviewer:
- Isn't paying sufficient attention to the code being submitted.
Don't get me wrong-- I've ripped away drywall to reveal nastiness before. But what you've described is systemic, and for that the reviewer must share some responsibility.
- scandox 8y agoLook I'm happy to take my part of the blame but some of what was wrong was so damn subtle. Ultimately one does trust people to make design decisions at some level of code that one does not second guess...
- jancsika 8y agoBut you wrote that none of the systems this developer implemented were even usable without intervention. What's the point of reviewing code if you don't eventually read some of it in enough detail to clamp down? Or at least revisiting the design of your tests.