3 ms·
The secret to good code review is addressing the code, not the person. Ask questions and make suggestions, rather than being critical of the other person. Inst
by jaggederest 8y ago
The secret to good code review is addressing the code, not the person. Ask questions and make suggestions, rather than being critical of the other person.
Instead of "Why would you ever do it this way?", try "I think I would probably do this like (example)"
Also, be liberal with complementary reviews, as well. I see a lot of pull requests where the solid, workday, well written code is just passed over, or given a ":+1:", even though it's definitely worthy of praise.
You wrote a new class extracted from an old confusing method, it has good tests, and the feature is working as requested? A triumph.