4 ms·

warning: the e2e implementor’s guide hasn’t been updated with any of the incremental key backup or interactive key verification stuff which just landed in Riot

warning: the e2e implementor’s guide hasn’t been updated with any of the incremental key backup or interactive key verification stuff which just landed in Riot 1.0, nor the cross-signing epic which is on the horizon. The details for these for those interested can be found at: https://github.com/matrix-org/matrix-doc/pull/1703 https://github.com/matrix-org/matrix-doc/pull/1703 https://github.com/matrix-org/matrix-doc/issues/1267 https://github.com/matrix-org/matrix-doc/issues/1267 https://github.com/matrix-org/matrix-doc/pull/1544 https://github.com/matrix-org/matrix-doc/pull/1544 and https://github.com/matrix-org/matrix-doc/pull/1756 https://github.com/matrix-org/matrix-doc/pull/1756

gregknicholson 8y ago
It's a good sign (I mean this sincerely!) when the first comment is the project founder with a caveat, setting realistic expectations. Keep up the good work! (…but do remember to get some bloody sleep every once in a while)
- Arathorn 8y ago
  thanks :)
cyphar 8y ago
Is there any plan to expose the Megolm session rotation parameters in the room configuration (I only just found out about them by reading the spec)? As an aside, I just tested setting the rotation parameters in an empty room, with key rotation set to every 5 messages, and the session_id was the same for all of my messages -- is Megolm rotation implemented in Riot?
- Arathorn 8y ago
  Hm, it should work, at least on matrix-js-sdk, based on a quick look at https://github.com/matrix-org/matrix-js-sdk/blob/907cf19f05411cdc4e590a5de9983d02a43d8e79/src/crypto/algorithms/megolm.js#L153-L190 https://github.com/matrix-org/matrix-js-sdk/blob/907cf19f054.... However, you're right that the UI isn't exposed in Riot currently, and the code may have bitrotted; looks like there isn't an explicit test for it.
  - cyphar 8y ago
    I figured it out -- the problem is that you cannot change the encryption parameters for a room, as any new m.room.encryption events are explicitly ignored[1]. I set up a new room and sent a custom state event and it worked. There is obviously a reason why you can't disable encryption once enabled, but it does suck that fields within m.room.encryption which are entirely advisory (since as far as I know the current implementation doesn't block messages that use old sessions) can't be changed. It's good to see that the session is being rolled somewhat frequently though. This does explain some of my questions about why the old-school key backups kept getting larger even though I haven't joined any new chats. [1]: https://github.com/matrix-org/matrix-js-sdk/blob/03a54353be98941c7e8c124393b386d0b6affc6f/src/crypto/index.js#L962-L968 https://github.com/matrix-org/matrix-js-sdk/blob/03a54353be9...

gregknicholson 8y ago

It's a good sign (I mean this sincerely!) when the first comment is the project founder with a caveat, setting realistic expectations. Keep up the good work! (…but do remember to get some bloody sleep every once in a while)

Arathorn 8y ago
thanks :)

cyphar 8y ago

Is there any plan to expose the Megolm session rotation parameters in the room configuration (I only just found out about them by reading the spec)? As an aside, I just tested setting the rotation parameters in an empty room, with key rotation set to every 5 messages, and the session_id was the same for all of my messages -- is Megolm rotation implemented in Riot?

Arathorn 8y ago
Hm, it should work, at least on matrix-js-sdk, based on a quick look at https://github.com/matrix-org/matrix-js-sdk/blob/907cf19f05411cdc4e590a5de9983d02a43d8e79/src/crypto/algorithms/megolm.js#L153-L190 https://github.com/matrix-org/matrix-js-sdk/blob/907cf19f054.... However, you're right that the UI isn't exposed in Riot currently, and the code may have bitrotted; looks like there isn't an explicit test for it.
- cyphar 8y ago
  I figured it out -- the problem is that you cannot change the encryption parameters for a room, as any new m.room.encryption events are explicitly ignored[1]. I set up a new room and sent a custom state event and it worked. There is obviously a reason why you can't disable encryption once enabled, but it does suck that fields within m.room.encryption which are entirely advisory (since as far as I know the current implementation doesn't block messages that use old sessions) can't be changed. It's good to see that the session is being rolled somewhat frequently though. This does explain some of my questions about why the old-school key backups kept getting larger even though I haven't joined any new chats. [1]: https://github.com/matrix-org/matrix-js-sdk/blob/03a54353be98941c7e8c124393b386d0b6affc6f/src/crypto/index.js#L962-L968 https://github.com/matrix-org/matrix-js-sdk/blob/03a54353be9...