3 ms·
I enjoyed the post. My feeling is that criticism, no matter what the domain, should be relatively dispassionate (neutral in tone), and come from a desire to he
by metabagel 8y ago
I enjoyed the post.
My feeling is that criticism, no matter what the domain, should be relatively dispassionate (neutral in tone), and come from a desire to help and with a dose of humility. Of course, I sometimes fall far short of that ideal.
- cortesoft 8y agoI actually feel that criticism should be empathetic rather than dispassionate... it should be worded to show that you understand the person is a competent professional who was working in good faith, but might have missed something or made a mistake. This is why I try to word reviews as questions, not statements of facts: "Is this supposed to be reversed? I think it might not do what you want it to" "Having a bit of trouble following this logic.. is there a way to make it more clear to future readers?" "I might be missing something, but I don't see how this code can be reached?" Don't give the review in such a way that implies you know everything and the other person was wrong. It should be a dialog, and be based on the assumption that we don't yet know the right answer and are working together to figure it out.