3 ms·

You don't have a review mandate before merge?

• mattmcknight 8y ago
  Yeah, but people might approve it for merge when it is not obvious that it isn't ready.
  • cco 8y ago
    Wouldn't this same person do the same for a Draft PR? i.e. if they're just reviewing things wouldn't they just set the Draft PR 'ready to review' and then review it? Or maybe I'm confused by your answer, are people commonly reviewing PR's without being asked?
    • CraftThatBlock 8y ago
      What the OP is saying is that someone can review a PR even when it's not ready by accident (not seeing WIP in title/tag), while with a draft, the reviews are disabled until its ready for review. This basically is a better WIP system than before because it can prevent accidental reviews and wasting time of re-reviewing when it actually is ready.
• deleted 8y ago
  [deleted]