3 ms·
This blog post really doesn't sell this feature well. How is this any different at all from me just putting "WIP" in the title of the PR? Ok, so it prevents mer
by peterwwillis 8y ago
This blog post really doesn't sell this feature well. How is this any different at all from me just putting "WIP" in the title of the PR? Ok, so it prevents merging a WIP PR - who would do that?
- bswinnerton 8y agoIf you use the `CODEOWNERS` feature, it won't auto-ping anyone until it comes out of the draft state.
- peterwwillis 8y agoAnd that's useful (if you use CODEOWNERS) - but just having a checkbox that says "don't ping the CODEOWNERS" on all PRs would have the same effect without needing a different type of PR.
- deleted 8y ago[deleted]
- michaelmior 8y agoAren't "PRs which should ping the CODEOWNERS" and "PRs which shouldn't" two types of PR anyway? Personally, I think it's useful calling it a draft and preventing the merge anyway.
- tln 8y agoThe differences seem minor to me. I create draft PRs all the time and probably won't bother with using this feature, because I usually open PRs using the `hub` tool or via VSCode, and only rarely via GH web site.
- tln 8y agoThat being said I must say I appreciate all the QoL features Github has been adding.