3 ms·
Other useful phrases: "Here, I was expecting to see...", "This code made me look at this other code and they cannot both be correct...", and "It took me a while
by jeffrallen 8y ago
Other useful phrases: "Here, I was expecting to see...", "This code made me look at this other code and they cannot both be correct...", and "It took me a while to see why this is correct. We could save the next reader time by..."
Excellent code reviews take time and attention, which is why you need auto code formatting and $lang proverbs to take the uncontroversial stuff off the table early. Then you still have brain power left to give value from the review.
Also: work hard to earn a reputation as a fair but tough reviewer. Then when you need to be a prick, people will know it's important and let their ego down.