3 ms·
Not a single test in the repository makes me a bit suspicious, quality-wise. The code is quite messy in general.
by V-2 8y ago
Not a single test in the repository makes me a bit suspicious, quality-wise.
The code is quite messy in general.
- fao_ 8y agoHave you seen Signal-Android's codebase.
- V-2 8y agoI'm still unable to unsee https://github.com/DrKLO/Telegram/blob/master/TMessagesProj/src/main/java/org/telegram/ui/ChatActivity.java https://github.com/DrKLO/Telegram/blob/master/TMessagesProj/... :)
- pandemic_region 8y agoWhat The Fuck ?
- yumoji 8y agoHope to improve it with your help. Pls fork and contribute.
- V-2 8y agoSome of it could be cleaned up fairly easily - like the use of Yoda conditions and other anti-patterns, numerous spelling mistakes, dead (commented out) code, redundant casts, unused variables etc. But the major problem is no separation of concerns (business logic is tightly coupled with UI logic and Android framework dependencies), which makes writing any automated tests for the thing next to impossible right now. Resolving this issue would require major refactoring.