3 ms·
Things I look for - - Is the commit message coherent ? Can I understand the intent of the CL from the message ? - If yes, then is this commit doing much...sho
by mav3rick 8y ago
Things I look for -
- Is the commit message coherent ? Can I understand the intent of the CL from the message ?
- If yes, then is this commit doing much...should it be split ?
- Is it functionally correct after a brief look at the code ?
Now on to the implementation -
- Are there any big functions ?
- Are there useless one line functions ?
- Is there too much nesting with conditionals ? Look for the snake pattern.
Concurrency -
- make sure that there is no cute "trick" to guarantee safety. Message passing preferred if not possible then basic locking techniques and language primitives. For eg ExecutorService in Java than reinventing your own wheel