3 ms·

You've also missed what was said on the mailing list message. Sun specifically made a new license to make it legally impossible to include DTrace and ZFS (and

You've also missed what was said on the mailing list message. Sun specifically made a new license to make it legally impossible to include DTrace and ZFS (and other things) into a GPL licensed project. That's a huge difference to what NIH means, which is that just because I didn't make it, I'm not going to use it, I'll make my own version instead. They couldn't ever use the original version of things because they're legally bound to not do so. The kernel has had a long standing policy of not keeping APIs that either they or userspace aren't using to reduce their burden and the case of keeping that API just for ZFS since literally nothing else in the kernel was using it wasn't a good enough argument to keep it. ZFS on Linux has now worked around the removal of the API.

pmoriarty 8y ago
"ZFS on Linux has now worked around the removal of the API." I'm just curious: how did they do that?
- Arnavion 8y ago
  https://github.com/zfsonlinux/zfs/commit/0c593296e98e3ac95f14704e4cee6cedb2134990 https://github.com/zfsonlinux/zfs/commit/0c593296e98e3ac95f1... + https://github.com/zfsonlinux/zfs/commit/26a856594f731db62446cf537659f9360261fe97 https://github.com/zfsonlinux/zfs/commit/26a856594f731db6244...
  - yjftsjthsd-h 8y ago
    > Linux 5.0 compat: Disable vector instructions on 5.0+ kernels Isn't that going to kill performance?
    - simcop2387 8y ago
      Probably not going to be very noticeable, most of the cost in calculating the checksums is in IO, but it will mean that there's a lower ceiling on total possible performance. That also assumes though that the cost for handling the vector instructions in-kernel isn't higher than doing it without them. I believe that was part of the reason that the kernel started removing this from within drivers and other parts to begin with, the cost of saving all the floating point registers and other state is actually surprisingly expensive. So it may be a complete wash in the end anyway. If the kernel is no longer having to worry about saving those registers it can mean that the userspace doesn't pay that extra cost and now your compute ability is better for it without seriously affecting any of the rest of the system.

pmoriarty 8y ago

"ZFS on Linux has now worked around the removal of the API." I'm just curious: how did they do that?

Arnavion 8y ago
https://github.com/zfsonlinux/zfs/commit/0c593296e98e3ac95f14704e4cee6cedb2134990 https://github.com/zfsonlinux/zfs/commit/0c593296e98e3ac95f1... + https://github.com/zfsonlinux/zfs/commit/26a856594f731db62446cf537659f9360261fe97 https://github.com/zfsonlinux/zfs/commit/26a856594f731db6244...
- yjftsjthsd-h 8y ago
  > Linux 5.0 compat: Disable vector instructions on 5.0+ kernels Isn't that going to kill performance?
  - simcop2387 8y ago
    Probably not going to be very noticeable, most of the cost in calculating the checksums is in IO, but it will mean that there's a lower ceiling on total possible performance. That also assumes though that the cost for handling the vector instructions in-kernel isn't higher than doing it without them. I believe that was part of the reason that the kernel started removing this from within drivers and other parts to begin with, the cost of saving all the floating point registers and other state is actually surprisingly expensive. So it may be a complete wash in the end anyway. If the kernel is no longer having to worry about saving those registers it can mean that the userspace doesn't pay that extra cost and now your compute ability is better for it without seriously affecting any of the rest of the system.