2 ms·
Huge mistake I caught a consultant making at the same company where I made the Sinatra server mistake. The company sent email alerts to customers whenever data
by bryanrasmussen 8y ago
Huge mistake I caught a consultant making at the same company where I made the Sinatra server mistake.
The company sent email alerts to customers whenever data changed. It turned out that a lot of people were not getting emails and they hadn't been for some months. The alerting system was written in Java (not my language), and was written by a part of the company in Argentina so not really anything to do with us.
The consultant was tasked with finding the bug, he stayed home to work on it so he could have no distractions.
I thought well I will look at code changes for the last few months, maybe I will notice something - and it turned out that the consultant tasked with finding the problem had some months ago made a change to the Java code dealing with alerting, which was weird. I went and looked at the before and after - the before was typical verbose Java code and I could sort of follow along and see it was for sending off alerts whenever the data changed ok. The new code seemed to just drop off into nothing halfway through.
So we were having a phone call with the consultant and he said well I am going to talk with 'head programmer in Argentina' in an hour to find out but can't figure out what is wrong.
And I Was like well I was looking through the code...
and you could see the consultant being somewhat annoyed at my chiming in because hey, what is Bryan doing looking at Java code he doesn't know crap about that language. I have to humor him, the big doofus. ugh. politeness sucks.
and I said so a could months ago somebody changed the code in this Java file here and their name was 'consultant name' and maybe that guy could help us figure out what the code is doing, because I don't think it will ever work.
And it turned out I was right and he was wrong and that was why many customers had not gotten their alerts for a couple months.
To pay for it he had to bring everybody pastries the next day.
About a week later I shipped a bug that made a bold text not bold on some types of documents. To pay for it I brought the biggest fanciest cake I could find, but I don't think anybody understood why.