3 ms·
- Vocal fry - It grates on me so much it's hard to concentrate. - Bashing the existing codebase immediately. You should at least have enough time to discover w
by sergiotapia 8y ago
- Vocal fry - It grates on me so much it's hard to concentrate.
- Bashing the existing codebase immediately. You should at least have enough time to discover why things were done a certain way before trying to suggest improvements.
- Adding significant changes without consulting ANYONE. One time this guys was brought on and decided all by himself to convert everything to Typescript and dockerize the app. Major red flag.
- Being offended at code reviews.
- Bad hygiene. If you smell like ass, please don't come into the office.
- When they assume too much prior knowledge and don't explain things explicitly. Like drawing blood from a god damn stone. Very frustrating. You don't want this person to be in charge of onboarding you.
- erulabs 8y agoWhile I agree with all of these, one employee _ought_ to be able to add typescript incrementally, or write a Dockerfile... Those are pretty straight-forward, incremental changes. I've seen entire organizations sit and bite their nails when someone says "Hey, mind if I write a Dockerfile for this app?". Same thing with types - while I regularly get into debates about typescript versus flowtype - I very rarely add a type-comment (still valid JS!) without a lot of hand-wringing over "maybe one day we'll all sit down and do this RIGHT... until then, no progress on this, okay?".
- gnahckire 8y agoI also agree w/ you on this one. I'd like OP to expand on why that's a red flag. Dockerization and using TypeScript seem pretty straightforward and logical additions to me. Also, if they're only additions, I wouldn't consider them significant changes. Using TypeScript can be a significant change but Dockerization? That seems pretty standalone isn't it?