3 ms·
Oh yes, so often the CR process becomes a hassle. Somebody positions themselves at the door as some sort of guard, and harasses everybody going through. So ofte
by JoeAltmaier 8y ago
Oh yes, so often the CR process becomes a hassle. Somebody positions themselves at the door as some sort of guard, and harasses everybody going through. So often just to feel like they're the boss or something.
My son just quit a startup because that had become epidemic. Couldn't get emergency code committed; couldn't meet (artificial) deadlines for demos and shows; every choice yammered over for esoteric reasons.
I suggest to everyone: when you make a comment in CR, also approve the commit. Trust the engineer on the other end to do what is necessary and responsible. If that become a problem, address it then. It seems like the minimum in professional respect.
- longerthoughts 8y ago>Somebody positions themselves at the door as some sort of guard, and harasses everybody going through. So often just to feel like they're the boss or something. I've noticed this outside of the CR process as well. When people are tasked with providing a critique, it's as if they feel obligated to say something because they're treating the task as "find something wrong with X" not "determine if anything is wrong with X". Sometimes it seems like people trying to exert their power, but often it's more like people are just trying to prove that they're adding value.
- hluska 8y ago> Sometimes it seems like people trying to exert their power, but often it's more like people are just trying to prove that they're adding value. If you work with people like this a lot, try introducing a shit sandwich to your company. Before you call your caterer, let me explain what that is...:) My Dad taught me that when you have to criticize/correct something, do so in a shit sandwich. Start off with positives, then express your criticism and then end with positives. Thinking about positives tends to ground people and get them to evaluate the situation, not merely come out with negativity to prove their worth...
- drbojingle 8y agoThis is common enough that everyone would know what you're doing and think you only said the nice things so you could say the negative :P
- hluska 8y agoGood point - sincerity is a big if in this process. If the good is genuine, this is an acceptable tradeoff, especially because thinking about positive things often makes the negative more gentle and more constructive.
- segmondy 8y agoPeople's live are more dependent on software, even a simple website can leak info that has devastating effect on folks. Treating software development casually is a big problem. If we are going to be professionals, then we need to be professionals, most folks love to call themselves "software engineers", then let's act like one. Would you like if the same approach was taken on the car you drive, elevators, planes, medical equipments, buildings? Building great software is a science not an art. If you wish to express yourself, go code demos, design levels and game play. Let me say this because I don't see it often said. Coding guidelines & Code review are a balancing act. One without the other is useless. Code review is where the correctness of the code is verified and we make sure that the guideline is followed. Without a guideline, the review process is just opinions. A guideline but without peer review is just a waste of time too. Guidelines must be reviewed often, it's a living document, that must be continually revised if need be to match the team and development process. If your guideline calls for indentation by 2spaces and you use 4, it's not harassment, it's a violation of understood principles. Now I must agree that the CR process should not be a bottleneck, if it is, it's a symptom of a bigger problem with the team and leadership. It's the leaders job to identify whatever it is and clear it so it can be fast and efficient.
- drbojingle 8y agoI can't personally agree with that viewpoint. If I know you're going to introduce a problem, it's my responsibility to say so then and there. If they're professional they need to respect that. Especially if it's CR from a junior.
- JoeAltmaier 8y agoIt's not a viewpoint; its a process. Comment and approve. Don't comment if its unrelated to the ticket being address; then write another ticket if the issue warrants it. Otherwise, save it for around the water cooler.
- UK-Al05 8y agoI don't understand why people hate CR. You're a professional you should be able to defend your code, and explain your reasoning. If you can't, you need to change it, and you'll improve at the same time. I mean most changes in code review only take 5 minutes to rectify, so I often don't buy the time argument. If you getting bit architectural change problems in your code review, you obviously didn't collaborate with the team very well... People should roughly know what your approach is before the CR even arrives at their door
- wrestlerman 8y agoI do think that code changes take more than 5 minutes, why? As a person, who pushed the code: 1. I have to read the comments 2. Decide if they are right/it's worth a hassle 3. Sometimes you have to reach out to the author of the comment to clarify some things. 4. Change your branch 5. Change your (thinking) context 6. Apply stuff 7. Push stuff 8. Notify the person that it's done. Many times it's more than 5mins, more like 10/15mins+ I don't hate CR. Someone below explained it better than me, that different people see the code differently. And you should respect that someone wrote it that way and not try to force your way upon them. > If you getting bit architectural change problems in your code review, you obviously didn't collaborate with the team very well... People should roughly know what your approach is before the CR even arrives at their door I agree with it a lot. I think that would solve a lot of problems, but not necessarily the small ones.
- JoeAltmaier 8y agoYes, but that's not what happens. Folks say "you tested for an empty pointer wrong" meaning not how they prefer. Or "This could be coded another way that I think is clearer". Here's a litmus test: if the comment has nothing to do with the correctness of the solution to the ticket, then don't comment. Instead write another ticket to address {whatever}. If it doesn't rise to the level of a ticket then guess what - you're being pedantic.
- mooreds 8y ago> I suggest to everyone: when you make a comment in CR, also approve the commit. Trust the engineer on the other end to do what is necessary and responsible. If that become a problem, address it then. It seems like the minimum in professional respect. When we do code reviews, we try to make things explicit. What needs to be changed, and what am I just commenting on to illustrate a different way to do it. Sometimes code is just wrong (either at the micro level--you forgot to remove that debug line--or at the macro level--you forgot this edge case) and a second set of eyes is a great way to catch it. But I agree, treating the original developer as a professional is a good idea.
- protonimitate 8y ago> when you make a comment in CR, also approve the commit. Trust the engineer on the other end to do what is necessary and responsible. If that become a problem, address it then. It seems like the minimum in professional respect. I agree wholeheartedly with this. One of my biggest pet peeves right now is having PRs delayed from merging because I can't get the required approvals over tiny non-vital changes. IMO a code review should only ever be rejected / not approved if it a) will bring down prod upon being committed, b) contains easily correctable but serious oversights (bad run time algos, potential NPEs, etc), or c) is built in a way that is not easily transferable / maintainable / goes against establish patterns by the team. Too many people use CR as a way to gatekeep and show off. I'm all for discussion, possible improvements, exchanging opinions, and learning - but not at the cost of leaving PRs in CR status for days on end.