3 ms·
It's not that PR are useless at all. This library has our most important code since it's used across all apps. However, the JSON definitions are just not that
by avitzurel 8y ago
It's not that PR are useless at all. This library has our most important code since it's used across all apps.
However, the JSON definitions are just not that important, that's a fact, we can ping engineers and have them lose focus just to get approve or we can decide to automatically approve if it's under directory "X".
I would argue that we did not implement a monolith at all, we just have a faster cadence to update dependency than most.
With the way this works, you can't forget anything and this is why this automation is so powerful, if you change the SDK, you know that everything using this SDK is updated with the latest code. It will either fail tests immediately or you can just move on with your life and focus on more important things
- deleted 8y ago[deleted]
- wickedOne 8y agowhich means your tests have a full coverage of code and scenarios?