4 ms·
> weird indentation This is regular BSD style, used in lots of places. Tabs for indentation, 4 spaces for wrapped lines. > ternary operator Totally fine here
by sjmulder 8y ago
> weird indentation
This is regular BSD style, used in lots of places. Tabs for indentation, 4 spaces for wrapped lines.
> ternary operator
Totally fine here IMO. Would get really verbose without.
> without braces
Again, regular BSD style and a matter of taste.
- taoistextremist 8y agoYeah, but I think they have a point about the variable names. Really hard to tell the significance of anything there.
- kazinator 8y agoLooks transparent to me. pdes must be "pipe descriptors". ifs probably refers to the IFS concept in the shell; it may have come from getenv("IFS"). wordexp is described as influenced by IFS, and this function may have to look at that variable even though it's calling an external program to pass it different arguments (which is a bit weird at first glance: the program seems dedicated to the purpose; why can't it handle that aspect internally). flags is probably coming from the wordexp flags argument; it's being tested using the documented bitmask constants in the API. Basically the coder here didn't just make up identifiers; they have connections to pervasive Unix concepts.