3 ms·

Doesn't do a great job with focus states. Hit tab and scroll through the page: * Buttons overview - Australian Government Design System || https://designsyste

Doesn't do a great job with focus states. Hit tab and scroll through the page: * Buttons overview - Australian Government Design System || https://designsystem.gov.au/components/buttons/ https://designsystem.gov.au/components/buttons/ And then compare it to this page: * Buttons | United States Web Design System || https://v2.designsystem.digital.gov/components/buttons/ https://v2.designsystem.digital.gov/components/buttons/ A lot of elements don't do a great job with lining up the focus states, they seem just sort of bolted on. Here are a few issues I saw: https://imgur.com/a/t0iwmWi https://imgur.com/a/t0iwmWi

chemicalnovae 8y ago
I mean...it's actually green and gold. But seriously, I can only think of a handful of official things that use the "official" colours, lots of sports teams but not really used by the government. Edit: Parent originally mentioned that the website doesn't use the "Official Australian Colours".
- dbg31415 8y ago
  Fair. I removed that part of the comment As an American living in Sydney, and working for an agency, I feel like accessibility is behind the US. This set of tools should help, but also the use of Lighthouse by QA teams is key. With Lighthouse, any score below 90 on any metric means our work fails QA —- it’s in our contracts to exceed 90. As a result, our clients rave about how easy it was to pass accessibility and security audits. Only secret is Lighthouse, and other automated checks, as part of the build process.
  - deadcat 8y ago
    The agency I work for is doing pretty extensive work to support JAWS 2018/2019, and NVDA. The problem we have is that a fix for a specific issue in JAWS may break NVDA (or cause double reads). Making everything work nicely in our Single Page Apps is a nightmare.
    - dbg31415 8y ago
      If you try and make it work after the fact, yes. Nightmare. If you know it's a target when you are in architecture, much easier to design it in a way that will pass the tests. Not saying that it's always perfect, but generally speaking having tests is better than not. Just key to have the tests early and often, so you can fix issues before they get baked in throughout a complex system.
alexpage 8y ago
Hey @dbg31415 we have created an issue. Thanks for the great feedback! https://github.com/govau/design-system-site/issues/388 https://github.com/govau/design-system-site/issues/388
- dbg31415 8y ago
  Cool, see my other comment as well -- for the agency I work for in Sydney, an 85 on Lighthouse would be a failing score. We need a 90 or higher on every metric to be able to hand it over to the client. Be useful to run a Lighthouse audit on your site and see what's causing the score to dip. Cheers!
  - alexpage 8y ago
    We just pushed fixes for the lighthouse issues. If you notice anything else feel free to let me know. Really appreciate the feedback! https://github.com/govau/design-system-site/pull/394 https://github.com/govau/design-system-site/pull/394 We have a lot of work to do for PWA's and performance. We have some issues open in the backlog however they will require some architectural changes and require a bit more time.

chemicalnovae 8y ago

I mean...it's actually green and gold. But seriously, I can only think of a handful of official things that use the "official" colours, lots of sports teams but not really used by the government. Edit: Parent originally mentioned that the website doesn't use the "Official Australian Colours".

dbg31415 8y ago
Fair. I removed that part of the comment As an American living in Sydney, and working for an agency, I feel like accessibility is behind the US. This set of tools should help, but also the use of Lighthouse by QA teams is key. With Lighthouse, any score below 90 on any metric means our work fails QA —- it’s in our contracts to exceed 90. As a result, our clients rave about how easy it was to pass accessibility and security audits. Only secret is Lighthouse, and other automated checks, as part of the build process.
- deadcat 8y ago
  The agency I work for is doing pretty extensive work to support JAWS 2018/2019, and NVDA. The problem we have is that a fix for a specific issue in JAWS may break NVDA (or cause double reads). Making everything work nicely in our Single Page Apps is a nightmare.
  - dbg31415 8y ago
    If you try and make it work after the fact, yes. Nightmare. If you know it's a target when you are in architecture, much easier to design it in a way that will pass the tests. Not saying that it's always perfect, but generally speaking having tests is better than not. Just key to have the tests early and often, so you can fix issues before they get baked in throughout a complex system.

alexpage 8y ago

Hey @dbg31415 we have created an issue. Thanks for the great feedback! https://github.com/govau/design-system-site/issues/388 https://github.com/govau/design-system-site/issues/388

dbg31415 8y ago
Cool, see my other comment as well -- for the agency I work for in Sydney, an 85 on Lighthouse would be a failing score. We need a 90 or higher on every metric to be able to hand it over to the client. Be useful to run a Lighthouse audit on your site and see what's causing the score to dip. Cheers!
- alexpage 8y ago
  We just pushed fixes for the lighthouse issues. If you notice anything else feel free to let me know. Really appreciate the feedback! https://github.com/govau/design-system-site/pull/394 https://github.com/govau/design-system-site/pull/394 We have a lot of work to do for PWA's and performance. We have some issues open in the backlog however they will require some architectural changes and require a bit more time.