3 ms·
Just some ideas: - Have a code review wiki document you can refer to for clear cut cases of things you have to fix without debate (e.g. naming convention issue
by seanwilson 8y ago
Just some ideas:
- Have a code review wiki document you can refer to for clear cut cases of things you have to fix without debate (e.g. naming convention issues) and things that are more subjective and don't have to be fixed (e.g. there can be more than one return per function).
- Code review suggestions should come with priority levels. Ignoring "nice to fix" problems shouldn't be a big deal if they're too time consuming and have little merit. This also helps draw attention to people that flag low merit issues as high priority.
- Use linter tools and autoformaters to stop people wasting time with certain nitpicks.
- Ongoing team discussions and training with concrete examples of which code review nitpicks aren't good uses of time might help.
If you've got team members saying nitpicks are high priority and making no considerations about how much time certain fixes are going to take then it's a training and experience problem you're going to have to address.
Can you give some examples of code review feedback you're not finding useful?