3 ms·
"when reviewing code, he's incapable of seeing anything but the negatives" isn't is the purpose of code review
by bra-ket 8y ago
"when reviewing code, he's incapable of seeing anything but the negatives"
isn't is the purpose of code review
- hellisothers 8y agoNo, the purpose is to give constructive feedback which is especially important when a senior eng is reviewing junior eng work and you’re trying to guide them with encouragement.
- Jemaclus 8y agoNope! It's part of the code review process, for sure, but it's not the purpose of code review. The purpose of code reviews is to have better code at the end of it. That includes pointing out bugs, improving fine-but-inefficient code, praising good code, encouraging documentation, and providing learning experiences for the developer and anyone else reading the review. Furthermore, interviews != code reviews. For an interview, not only is the candidate putting their best foot forward, but the interviewer should be putting their best foot forward, as well. It doesn't matter if Joe is the best programmer in the company -- if he's abrasive, you don't want to put him in front of prospective candidates.