3 ms·

I really enjoyed the Ousterhout book as well. It's my current user manual for reviewing pull requests. Putting my PR reviewer hat on I would say the code in q

I really enjoyed the Ousterhout book as well. It's my current user manual for reviewing pull requests. Putting my PR reviewer hat on I would say the code in question would pass muster if it were relatively stable so you would not be constantly redoing the comments. I love nice comments but Golang does not give you much help keeping them in sync. (Weirdly enough I'm working on a PR for persistent volume documentation at VMware today so the code is very apropos.)

AlexCoventry 8y ago
> Golang does not give you much help keeping them in sync. What do you have in mind, here? Something like python's doctest?
- scns 8y ago
  Elixir tests code in comments for correctness
- hodgesrm 8y ago
  Javadoc. It generates warnings if method argument documentation does not line up with the method signature, for example.