3 ms·
https://github.com/pypa/pipenv/issues/1382 https://github.com/pypa/pipenv/issues/1382 ^ This was just such a glaringly terrible design decision, and the fact t
by cellularmitosis 8y ago
https://github.com/pypa/pipenv/issues/1382 https://github.com/pypa/pipenv/issues/1382
^ This was just such a glaringly terrible design decision, and the fact that they won't even acknowledge it as being a mistake is really frustrating.
npm already found the best solution (if ./node_modules exists, it is automatically used -- no need to run any sort of shell commands). All they had to do was just copy their behavior.
Oh well, maybe the _next_ python virtual environment tool will get it right... :(
Python is a great technology but it is really a shame that is hampered by bad decisions (e.g. the 2->3 fiasco).
- joshuamorton 8y agoThe behavior you describe is great until you run `py.test myproject` and it proceeds to invoke all of the unit tests for tensorflow or whatever.
- scrollaway 8y agoThat's absolutely the sort of thing that can be fixed in pytest's test discovery algorithm. It's not like this isn't exactly the same fix as in the js world (= ignore node_modules in test discovery).
- joshuamorton 8y agoSure but then you have a chicken/egg problem: pytest isn't the only testing library that does test discovery (standard library unittest does too, among tons of other 3p ones). Does everyone follow pipenv's convention? Do you write a PEP? What's the solution (maybe a pep-like is the right one to be honest), but its not an immediate change, and makes people less likely to use your tool in the interim. Kenneth used a growth hack.