3 ms·

Years ago I disabled github notifications and ignored pull requests because honestly, 95% of them are crap. So many of them degrade performance, break unrelated

by ggreer 8y ago

Years ago I disabled github notifications and ignored pull requests because honestly, 95% of them are crap. So many of them degrade performance, break unrelated features, or are incompatible with certain platforms. I don't have the time or inclination to sift through them all to figure out which 5% are good, especially since I'm not getting paid for it. Sorry.

RayDonnelly 8y ago
So it's not really an open source project in any meaningful way? Do you consider it reasonable for people to waste their time making PRs and working trying to help you to improve the silver searcher? Could you put something up describing this policy? Could you recruit someone who's proven themselves to be maybe somewhere near as good as you to be a co-maintainer? As I say I couldn't care less about my PR now since I've moved to rg, but this was an absolutely horrible experience. Either embrace open source and do it right or please, do not bother releasing source code.
- ggreer 8y ago
  Other people want to modify my project, usually in ways that break it, and somehow I am obligated to provide my time and skills to them for free? I don't understand where you're coming from at all.
  - RayDonnelly 8y ago
    You answered none of my explicit questions. Hopefully a maintainer with a sense of community and responibility will fork the silver searcher.
  - RayDonnelly 8y ago
    You don't want to waste your own precious time but are more than happy for many other people to waste theirs? Also you merged commits starting from 24 Dec 2011 and ending on 18th August. Presumably you saw value in those commits?
- burntsushi 8y ago
  As the maintainer of ripgrep, I'd like to respectfully ask you not to harass other maintainers of open source projects about how they spend their free time. I've been where ggreer is and it's not pleasant. I completely understand their position, and a little empathy on your part would go a long way. In an ideal world, the maintenance status of a project would be mentioned in the project README, but speaking from personal experience, this is seemingly difficult to do in practice.
  - RayDonnelly 8y ago
    I respectfully disagree with you. I wasted perhap 10 hours of my life or more on this PR (pointlessly rebasing it a few times). 95 other PRs are outstanding. There are many ways to improve this situation. I pointed two of them out: 1. Declare that you won't accept (or even review) them, preferably at the top of README.md * 2. Give a second person merge status. I have some empathy for the maintainer but I also have empathy for the prospective contributors who spent a chunk of their free time working on https://github.com/ggreer/the_silver_searcher/pulls https://github.com/ggreer/the_silver_searcher/pulls I've done my bit here to stop wasting people's time globally, I don't consider a maintainer's time more valuable than a contributor's time. That's elitest nonsense. https://github.com/ggreer/the_silver_searcher/issues/1284 https://github.com/ggreer/the_silver_searcher/issues/1284 * The likely side-effect is a unblessed fork (or people not wasting their time, or if they do, well, they didn't read the README.md and cannot be too annoyed at anyone but themselves).
    - ggreer 8y ago
      Come on dude, I just want to enjoy my long weekend. Please stop bothering me by creating spurious issues on my GitHub repo.
      - RayDonnelly 8y ago
        OK sure, but would you consider merging one PR that explains that people should not expect PRs to get reviewed? I'm happy to do the work if you'll review and merge it. That way we can avoid unfortunate incidents such as this in future.

by ggreer 8y ago

RayDonnelly 8y ago

So it's not really an open source project in any meaningful way? Do you consider it reasonable for people to waste their time making PRs and working trying to help you to improve the silver searcher? Could you put something up describing this policy? Could you recruit someone who's proven themselves to be maybe somewhere near as good as you to be a co-maintainer? As I say I couldn't care less about my PR now since I've moved to rg, but this was an absolutely horrible experience. Either embrace open source and do it right or please, do not bother releasing source code.

ggreer 8y ago
Other people want to modify my project, usually in ways that break it, and somehow I am obligated to provide my time and skills to them for free? I don't understand where you're coming from at all.
- RayDonnelly 8y ago
  You answered none of my explicit questions. Hopefully a maintainer with a sense of community and responibility will fork the silver searcher.
- RayDonnelly 8y ago
  You don't want to waste your own precious time but are more than happy for many other people to waste theirs? Also you merged commits starting from 24 Dec 2011 and ending on 18th August. Presumably you saw value in those commits?
burntsushi 8y ago
As the maintainer of ripgrep, I'd like to respectfully ask you not to harass other maintainers of open source projects about how they spend their free time. I've been where ggreer is and it's not pleasant. I completely understand their position, and a little empathy on your part would go a long way. In an ideal world, the maintenance status of a project would be mentioned in the project README, but speaking from personal experience, this is seemingly difficult to do in practice.
- RayDonnelly 8y ago
  I respectfully disagree with you. I wasted perhap 10 hours of my life or more on this PR (pointlessly rebasing it a few times). 95 other PRs are outstanding. There are many ways to improve this situation. I pointed two of them out: 1. Declare that you won't accept (or even review) them, preferably at the top of README.md * 2. Give a second person merge status. I have some empathy for the maintainer but I also have empathy for the prospective contributors who spent a chunk of their free time working on https://github.com/ggreer/the_silver_searcher/pulls https://github.com/ggreer/the_silver_searcher/pulls I've done my bit here to stop wasting people's time globally, I don't consider a maintainer's time more valuable than a contributor's time. That's elitest nonsense. https://github.com/ggreer/the_silver_searcher/issues/1284 https://github.com/ggreer/the_silver_searcher/issues/1284 * The likely side-effect is a unblessed fork (or people not wasting their time, or if they do, well, they didn't read the README.md and cannot be too annoyed at anyone but themselves).
  - ggreer 8y ago
    Come on dude, I just want to enjoy my long weekend. Please stop bothering me by creating spurious issues on my GitHub repo.
    - RayDonnelly 8y ago
      OK sure, but would you consider merging one PR that explains that people should not expect PRs to get reviewed? I'm happy to do the work if you'll review and merge it. That way we can avoid unfortunate incidents such as this in future.