3 ms·
This is a great real world example. However I would rate your first PR as very good... Documentation improvement, with examples, is something which is very hard
by antirez 8y ago
This is a great real world example. However I would rate your first PR as very good... Documentation improvement, with examples, is something which is very hard to get. Btw in general, I totally agree with the basic idea of trying to merge trivial patches. I go a step forward and I merge "just typos" PRs even if they have the bad effect of breaking other very important PRs sometimes, because a trivial break will be a trivial rebase anyway and typos cannot stay there forever.
From this POV btw Github does a terrible job not telling maintainers: "merging this PR will result in the following PRs being no longer mergeable". Most of the times the list would be empty, making the merging of small PRs a lot more a non brainer.