3 ms·
I've done this for a few projects, and it's almost always a PR to fix a specific pain point that I've had, that isn't obvious from the PR itself. Examples are
by strken 8y ago
I've done this for a few projects, and it's almost always a PR to fix a specific pain point that I've had, that isn't obvious from the PR itself. Examples are
- downcasing some http headers in an example (because they wouldn't match unless downcased, which I spent hours figuring out)
- replacing a regex search with a string search (because it made the method 30x faster and it was on the critical path of a weird edge case)
- allowing the user to prevent some harmless automatic stats being loaded in a postgres library on connect (because it broke cockroachdb, which uses the same wire protocol)
- quoting the urls in some generated CSS (because in base64 "//" is sometimes a valid encoding and our CSS preprocessor implemented line comments)
Now, I left a description for all of these that explained the problem, but without context they'd just look like I was collecting "contributor" labels.