4 ms·
This will break, i.e. two consecutive rotations will no longer be the identity, if the number of valid characters in the BMP ever becomes odd. And there are sti
by danbruc 8y ago
This will break, i.e. two consecutive rotations will no longer be the identity, if the number of valid characters in the BMP ever becomes odd. And there are still a few unallocated code points in the BMP. There is also an overflow in line 39 because of the check i <= BMP_SIZE in line 37 which, I guess, previously used Char.MaxValue instead of BMP_SIZE. But it does no harm here, U+0000 just gets filtered out twice.
- platforms 8y agoThere's a test for BMP characters being even: https://github.com/rottytooth/rot8000/blob/master/Rottytooth.Rot8000.Tests/MappingsTests.cs https://github.com/rottytooth/rot8000/blob/master/Rottytooth... More critically, if the # of valid chars changes, previously rot-8000'd text will no longer be reversible through the tool