3 ms·

Go to Github and look at projects where there have been a few recent merged pull requests. Look at listed issues, the TODO file and so forth. Fix an issue and

by Ologn 8y ago

Go to Github and look at projects where there have been a few recent merged pull requests. Look at listed issues, the TODO file and so forth. Fix an issue and send a pull request. After a few such patches, this will start getting you code reviews. People have much more time to review your patches to their code than they do to make suggested patches to your code.

manuchroma 8y ago
How I learnt to write better code. +1 on doing so.
lostapathy 8y ago
Adding on - look at recently closed PRs and see if they get reviews like you're looking for. If not - keep looking until you find a project at the intersection of your skills and desire for feedback. This will take a fair bit of work, but it's worth it. And of course - don't take things too personally, but also don't take them too seriously either. Plenty of open source projects have drive-by "code reviewers" that nitpick everything without contributing themselves. All things in moderation
mattfrommars 8y ago
I was just going through GitHub and couldn't find how to do "few recent merged pull request". Any pointer?
- Ologn 8y ago
  Well let's say you know Kotlin well and program for the Android platform a lot. You can search Github for projects using the Kotlin language which contain the word Android, with the most stars like this: https://github.com/search?o=desc&q=language%3AKotlin+Android&s=stars&type=Repositories https://github.com/search?o=desc&q=language%3AKotlin+Android... We go down six and see Google's android architecture components. We click on it and click on pull requests. We look at what is open and what is closed. We see a month ago someone sent a pull request which was merged - https://github.com/googlesamples/android-architecture-components/pull/479 https://github.com/googlesamples/android-architecture-compon... If we go back more we can see other merged requests in the recent past. This is a project with a "few recent merged pull requests". People sent a patch to the code in a pull request, and their branch was merged into the main code base. While this example was Android and Kotlin, you can look at other languages you have more familiarity with, and other focuses. Projects with a lot of stars and/or forks are good candidates to look at, and you can sort by them. I did add the caveat recent though, as sometimes a project has been abandoned for a year or more, and there might be no active project owner to merge pull requests.

by Ologn 8y ago

manuchroma 8y ago

How I learnt to write better code. +1 on doing so.

lostapathy 8y ago

Adding on - look at recently closed PRs and see if they get reviews like you're looking for. If not - keep looking until you find a project at the intersection of your skills and desire for feedback. This will take a fair bit of work, but it's worth it. And of course - don't take things too personally, but also don't take them too seriously either. Plenty of open source projects have drive-by "code reviewers" that nitpick everything without contributing themselves. All things in moderation

mattfrommars 8y ago

I was just going through GitHub and couldn't find how to do "few recent merged pull request". Any pointer?

Ologn 8y ago
Well let's say you know Kotlin well and program for the Android platform a lot. You can search Github for projects using the Kotlin language which contain the word Android, with the most stars like this: https://github.com/search?o=desc&q=language%3AKotlin+Android&s=stars&type=Repositories https://github.com/search?o=desc&q=language%3AKotlin+Android... We go down six and see Google's android architecture components. We click on it and click on pull requests. We look at what is open and what is closed. We see a month ago someone sent a pull request which was merged - https://github.com/googlesamples/android-architecture-components/pull/479 https://github.com/googlesamples/android-architecture-compon... If we go back more we can see other merged requests in the recent past. This is a project with a "few recent merged pull requests". People sent a patch to the code in a pull request, and their branch was merged into the main code base. While this example was Android and Kotlin, you can look at other languages you have more familiarity with, and other focuses. Projects with a lot of stars and/or forks are good candidates to look at, and you can sort by them. I did add the caveat recent though, as sometimes a project has been abandoned for a year or more, and there might be no active project owner to merge pull requests.