2 ms·
Sure, but in the end, if you allow new features to regress compile times, and you keep adding new features, then compile times are probably going to increase in
by foldr 8y ago
Sure, but in the end, if you allow new features to regress compile times, and you keep adding new features, then compile times are probably going to increase in the long run. (The logic here being that there are always more people interested in implementing new features than there are people interested in improving compile times.)
However, some of the other comments suggest that NLL is actually a bug fix. If so, then obviously a performance regression is better than a buggy borrow checker.
- steveklabnik 8y agoWe track compile times on a per-commit basis. We don’t allow major regressions. But engineering is all about making hard calls. And, as the post mentions, while this may be a small regression in this particular step of the compiler, in an Amdahl’s Law sense, the speed of this step is not that big of a proportion of overall compile times. Most users won’t feel this difference. They do feel the pain of lexical lifetimes quite a bit, though. Which makes it a good trade off, even without regard for the soundness fixes.
- foldr 8y agoI'm just putting a data point out there. Me = Rust user who'd rather have slightly faster compile times. But it's moot anyway given that this is a bug fix.
- steveklabnik 8y agoYes, you are one of many. Everyone wants faster compiles.
- nicoburns 8y agoI'm also in the "really need faster compile times" camp. You may be interested in this thread on rust internals https://internals.rust-lang.org/t/next-steps-for-reducing-overall-compilation-time/8429/11 https://internals.rust-lang.org/t/next-steps-for-reducing-ov...
- kibwen 8y agoFor reference, there's a tag on the issue tracker for things that have been blocked on NLL to fix: https://github.com/rust-lang/rust/labels/NLL-fixed-by-NLL https://github.com/rust-lang/rust/labels/NLL-fixed-by-NLL Look for the ones that are also tagged "unsound" for the most serious instances.