3 ms·
So this is actually a major bug fix rather than an ergonomic improvement?
by foldr 8y ago
So this is actually a major bug fix rather than an ergonomic improvement?
- steveklabnik 8y agoIt’s both.
- foldr 8y agoOk, good to know. That's definitely not how it's presented in the blog post.
- steveklabnik 8y agoMost people care way more about the ergonomic improvement than they do the soundness fixes, because the soundness issues are very, very rare, but the ergonomic pain is very present.
- foldr 8y agoNo-one would suggest that the dev team ought to hold off on a soundness fix for performance reasons. It seems like it would be worth mentioning that aspect of NLL when raising the issue of compile times. I certainly would not have made my original comment if the blog post had made that clear.
- Twirrim 8y agoAs mentioned in the first line of the blog post (and linked) it was essentially a follow-up to another blog post, http://smallcultfollowing.com/babysteps/blog/2018/10/31/mir-based-borrowck-is-almost-here/ http://smallcultfollowing.com/babysteps/blog/2018/10/31/mir-... which describes the state of NLL, which also gives an example of bugs fixed by NLL and why it's desirable. This one was purely focussing on the performance side of things mentioned on that previous blog post.
- foldr 8y agoThat post briefly mentions bug fixes in the text, but doesn't actually give any examples.
- kibwen 8y agoHere's a runnable example of a bug that NLL fixes; remove the feature flag up top to observe the use-after-free: https://play.rust-lang.org/?gist=761478ea89b3cd1df50ee274cb7a909d&version=nightly https://play.rust-lang.org/?gist=761478ea89b3cd1df50ee274cb7...