5 ms·
Hilariously awesome. I'm curious whether the multiple warnings about running untrusted code in the browser are necessary. I feel like all websites are already
by dahart 8y ago
Hilariously awesome.
I'm curious whether the multiple warnings about running untrusted code in the browser are necessary. I feel like all websites are already untrusted code, and the browser is quite well sandboxed and protected from anything too bad happening. What is the worst case scenario here for the user within the JS ecosystem, under known avenues of attack, not counting an unknown zero day browser exploit?
- pc86 8y agoI can't speak to the worst case scenario as I'm not very knowledgeable about browser sandboxing or what JS can['t] do in a given context. But as a developer I do think there's a pretty significant difference between running code that someone wrote on their own website and loading arbitrary code from a third party then executing that without any human looking at the code.
- dahart 8y agoThat’s more or less what all iframed ads are. Plus most popular web sites load libraries for services where the site owners can’t easily see what’s happening under the covers. Google analytics would be an example of this, but there are many, and lots of sites use multiple such services.
- pc86 8y agoI see what you're saying and I agree for the most part, but all that code is written by someone, reviewed (maybe), and put to some form of a production environment. The code in StackOverflow is usually just typed right into the answer box and submitted. I know I've edited answers where there were compilation errors in the accepted solutions! Not strictly relevant to JS of course.
- wlesieutre 8y agoThat's how it should work with ad networks, but you really never know what code you're going to end up serving. https://www.trendmicro.com/vinfo/vn/security/news/cybercrime-and-digital-threats/forbes-readers-served-malicious-ads-after-asking-them-to-disable-adblocker https://www.trendmicro.com/vinfo/vn/security/news/cybercrime...
- template3 8y agoThis is unintentionally fucking hilarious. You already concede that review is a “maybe”... so we have to assume it won’t happen. So basically your argument boils down to web code meeting the high standards of being “written by someone” and put in “some form” of a production environment. Any http server on a routable ip address qualifies as “some form” of production environment.
- pc86 8y agoYou don't think there's the slightest bit of difference between production code written at even very dysfunctional organizations with mediocre developers, and random answers on StackOverflow? And you've only been here for a few weeks so I'll give you the benefit of the doubt, but calling something "unintentionally...hilarious" is usually taken as just another way of calling someone an idiot. I'd suggest you try to find ways to make your point without deriding those who don't share your view, especially on something so inconsequential.
- nothrabannosir 8y ago> You don't think there's the slightest bit of difference between production code written at even very dysfunctional organizations with mediocre developers, and random answers on StackOverflow? I do; a random SO answer will be miles better than anything coming out of an average organisation. To write an SO answer, you need to actually care about answering SO questions. To write code in an average company, you need to... have a pulse, it seems.
- template3 8y agoWell I speculated the that you were not going for hilarious. And I found it funny so that’s why I said unintentionally. And here’s why. Your general comment follows the classical salesman or marketing response to “why should I trust you?” And the expected response being oh well we have the finest, best trained developers from the best schools and everything is carefully reviewed, and we run everything on the best maintained equipment in a secure data center. Except what you said had those things with no minimum standard... basically demolishing your premise. I read it like a sales pitch and it made me chuckle. “Our code is written by someone, maybe reviewed, and runs on some form of production hardware.” And the serious thing is... there is no minimum standard for the code that will run on your browser and anybody that works in this field really should understand that. Anybody that believes anything other than the web is a 100% untrustable shithole is liable the type to architect the next Equifax. And I felt your comment inadvertently just supported this opinion, so there’s that. https://www.google.com/amp/s/www.networkworld.com/article/3021113/security/forbes-malware-ad-blocker-advertisements.amp.html https://www.google.com/amp/s/www.networkworld.com/article/30... Also yes I fully expect most code on stackoverflow to be of higher quality than most internal LOB code written (i’ve seen a lot of code at this point). If anything stackoverflow makes the mediocre shops better insofar as they copy from it.
- seba_dos1 8y agoThat's exactly why I would rather trust code from random SO answers than from the ad network.
- Uehreka 8y agoOf note though, cross-domain iframes have intense restrictions on them to prevent them from XSS-ing the host page or its domain. Of course, if you’re running 3rd party ad scripts on your actual page, you’re at their mercy.
- PhrosTT 8y agoI'm sure at the very least some of the sorts are incorrect and will brick your browser tab from an infinite loop or something.
- retbull 8y agoThats crazy talk everything on Stack Overflow is correct because it has the most upvotes.
- nicoburns 8y agoTo be fair, I'd imagine the code in SO answers is less likely to be malicious than the code in adverts on most news websites...
- camelCaseOfBeer 8y agoWe're a small tribe, you and I; our hunting ground for answers, the minified JavaScript from pop-up ads. The white-devil of SO will never understand the respect for code in it's natural environment. We love the challenge, the existential search for truth and purpose. A Red-Tailed hawk cries in the distance.
- CPLX 8y agoBut what if it’s the answer to the question how do you brick your browser tab from an infinite loop?
- toomuchtodo 8y agoYou've discovered a new unit test.
- jxcole 8y agoThe standard attack in this case is that someone could steal your cookies (if they are Js cookies) or execute instructions on gkoberger.github.io without your permission, since that is the context. The way you would do this is create an answer to one of these questions on stack overflow that includes malicious javascript. However, it's kind of unlikely there is much you can do with it. Sometimes a site will share cookies with subdomains, but this is not likely for github because you are allowed to publish arbitrary js there, so that would be a huge security hole.
- Uehreka 8y agoThis is why GitHub uses a separate domain (github.io as opposed to github.com) for user sites.
- floil 8y agoMoreover, github.io is in the public suffix list, so it is effectively a TLD (foo.github.io is a different site from bar.github.io; they can't become same origin by means of document.domain). The risk of eval() is giving control of the site data of foo.github.io to the author of a stackoverflow comment. The warning is part of the fun, though.
- _puk 8y agoGithub hasn't always used a seperate domain for user sites [0]. They do now to directly address the GP's concerns. http://homakov.blogspot.com/2013/03/hacking-github-with-webkit.html http://homakov.blogspot.com/2013/03/hacking-github-with-webk...
- Uehreka 8y agoGiven that this site is not hosted on a domain where you have important session cookies (or where you’ve granted permissions like camera or location usage) I don’t see much problem with eval-ing untrusted code. Most of the common XSS threats just don’t apply here.
- Seirdy 8y agoI run a Flatpak'd browser with limited privileges, so the worst that can happen is my `~/Downloads` folder gets messed up.
- duxup 8y agoReminds me of "security expert" warnings in the mass media where every time something happens they tell people effectively the same thing "don't do things unless you know / trust it". Most people have no clue what they're running and can't possibly take the time to know enough to really have a clue.
- ndnxhs 8y agoTrust is fairly worthless as well. Malware devs buy trusted software to turn in to malware so something that was good and trusted for years is now bad with no warning.
- jaco8 8y agoExactly my thought too. Trust,however, is a weakness. This weakness is overcome by the average web surfer due to knowledge and time constraints or unintended clicks on links and ads. The future hopefully will have security audited browsers which increasingly minimize dangers arising from these actions.
- zeven7 8y agoSome worst case scenarios: - Your tab freezes due to an infinite loop for a while until your browser notices and asks you if you want to kill the script. - The script downloads illegal content, and your ISP notifies authorities. - CSRF attack against a site you're signed into that's not properly secured. All of these things are things any site you go to can do. There's nothing special about `eval` that makes this site more dangerous.