3 ms·

Argh. This is a turn-off for sure but it seems like the issue can be easily remediated by stripping the color codes from the initrd image

• woodruffw 8y ago
  Ideally, but it might not be reversible: if the same bytes that make up an ANSI escape + red color code just happen to already be in initrd, then the strip would remove those as well. I think the best solution here is probably to avoid `sudo -E`, and for `stderred` to be patched to not perform any monkeypatching when `uid == 0`.
  • saagarjha 8y ago
    LD_PRELOAD is not respected for setuid binaries, right? So why do we need a special case here?
    • kcolford 8y ago
      Because sudo is the setuid binary here (so it's not affected) but everything else isn't setuid, they're just running under sudo with LD_PRELOAD set...
      • saagarjha 8y ago
        sudo -E should not pass LD_PRELOAD through anyways; at least, the one I'm using on macOS 10.14.2 and the Ubuntu 14.04 box I just SSHed into doesn't do this. It looks like the issue is that sudo -s causes LD_PRELOAD to be set again as root because ~/.bashrc is sourced again.